Skip to content

Commerce Datattype Price isn't saving in splitview #695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cryothic opened this issue Apr 28, 2025 · 10 comments
Closed

Commerce Datattype Price isn't saving in splitview #695

cryothic opened this issue Apr 28, 2025 · 10 comments

Comments

@cryothic
Copy link

cryothic commented Apr 28, 2025

Which component is this issue related to?

Umbraco Commerce (Core)

Which Umbraco Commerce version are you using? (Please write the exact version, example: 10.1.0)

13.1.4 (and still remains after updating to 13.2.1)

Bug summary

It seems the price field isn't saving when you have a page open in split-view.
I have this same issue in Vendr sites too, but I was hoping it was fixed in Commerce.

I have also tried saving field of type Umbraco Commerce: Stock and Umbraco Commerce: Measurements, but they are saved correctly. The only problem I've found so far was with the price field.

Specifics

No response

Steps to reproduce

  • Have a site with (at least) 2 languages
  • Have a product doctype with a Textstring-field (for verification), and a Umbraco Commerce: Price field.
  • Set the textfield to "vary by culture", the price field is NOT "vary by culture".
  • Open the product page in the content editor
  • Open the second language via split view
  • Enter a text in the text field
  • Enter a price in the price field
  • Click "Save and publish"

Expected result / actual result

I would expect after saving, the new values are in place.

But the price value isn't saved.

If I started with an empty product page, after saving the textfield contains text and the price field is empty.
If I started with an allready filled product page, the textfield gets updated but the price value gets reset to it's previous value.

pricefield_save.mp4

Dependencies

No response


This item has been added to our backlog AB#52353

@cryothic cryothic added the bug Something isn't working label Apr 28, 2025
@mattbrailsford
Copy link
Contributor

mattbrailsford commented Apr 28, 2025

Can you upgrade to 13.2.1 and see if the issue is still present. Not sure there is anything in the release notes that suggest it would be fixed, but we'd need you to be on the latest v13 anyway before we can look into it.

@cryothic
Copy link
Author

@mattbrailsford Hi Matt,
I've updated to Version: 13.2.1.
The problem still exists.

@mattbrailsford
Copy link
Contributor

@cryothic thanks for checking. I'll get this added to our backlog to investigate 👍

@mattbrailsford
Copy link
Contributor

Ok, I've managed to replicate this. Ultimately the Price property waits for a "formSubmitting" event to write it's value back to the model, but it looks like both views trigger that event and so both views cause a save, but the second views wins and so because the value isn't synchronizing, the new value gets overwritten by the old value

@mattbrailsford
Copy link
Contributor

Ok, I've pushed a 13.2.2--preview.2 build to our nightly feed, if you'd like to give that a try I think it should solve your issue.

@cryothic
Copy link
Author

cryothic commented May 2, 2025

Hi @mattbrailsford
I've updated my test-project to the 13.2.2--preview.2 build.

This seems to work. If I now change the price, it get's updated after saving in both views.

I've noticed the field isn't syncing realtime though.
If I change any other field, it instantly updates in both views as if I'm typing in 2 textboxes at the same time.
The price-field isn't doing that.

But the saving self seems to work.

@mattbrailsford
Copy link
Contributor

Ahh, yea, good point.

Just pushed a new 13.2.2--preview.3 build that should take care of that 👍

@cryothic
Copy link
Author

cryothic commented May 2, 2025

That was quick.
Works like a charm now. Thanks.

@mattbrailsford
Copy link
Contributor

Ok great, I'll schedule this for release next week but you are welcome to keep using the nightly in the meantime.

@umbracotrd
Copy link

13.2.2 is out now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants