V15: Icon color for selected node in link picker

[bjarnef]

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

15.3.0-rc

Bug summary

I noticed in link picker that the icon for a selected node has contrast enough to background color for default document icon:

but not other icons:

Specifics

No response

Steps to reproduce

Select content nodes via link picker and notice contrast between background and icon.

Expected result / actual result

No response

[github-actions]

Hi there @bjarnef!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

• We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
• If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
• We'll replicate the issue to ensure that the problem is as described.
• We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

[NguyenThuyLan]

Hi @bjarnef , I couldn't reproduce your issue on the latest code of v15.3.0-rc like this video (on both Chrome and Firefox). Could you provide more details?

Umbraco.-.Google.Chrome.2025-03-04.09-17-23.mp4

[bjarnef]

Okay, it may already has been fixed. I recall some recent changes regarding treenode icon color, but the contrib branch is quite many changes behind devepment branch.
https://github.com/umbraco/Umbraco-CMS/tree/v15/dev

[bjarnef]

Ensure an icon color is set for content type as well as I think it by default not set the color.

[NguyenThuyLan]

@bjarnef , v15/dev was merged into contrib, could you recheck the issue again now?

[bjarnef]

@NguyenThuyLan I will check.

I noticed some obsolete warnings that would be removed in V15, but UmbracoApiControllerTypeCollection and UmbracoApiControllerTypeCollectionBuilder is still present.
https://github.com/search?q=repo%3Aumbraco%2FUmbraco-CMS%20UmbracoApiControllerTypeCollection&type=code

[bjarnef]

Pulled latest changes, it didn't fix the issue though, because of this:

It does work for nodes, where one doesn't explicit set color.

[bjarnef]

It is clearly an issue when checking child nodes of a document type.

It can be reproduced installing the default starter kit: https://marketplace.umbraco.com/package/umbraco.thestarterkit

[NguyenThuyLan]

Thanks @bjarnef , I will look at the contrib branch. For obsolete warnings, well, we don't have an exact timeline for the individual obsoletions, but we'll be doing an effort to clean up as many as we can for V16

[NguyenThuyLan]

Hi @bjarnef , I still couldn't reproduce it on latest code on both branches, I will move this issue to thestarterkit

[lauraneto]

I was able to reproduce this in a clean 15.4.1 Umbraco install (no starter kit) and in the main branch of the CMS.
In short, the icon only changes color when selected (in this case, turns white) if you haven't picked a color when selecting the icon. If you did pick a color (which includes manually selecting black), then the icon will remain the picked color independently of whether it is selected or not.

This is especially (non-)visible when you pick blue, which is the same color as the selection 🙈

Found this commit, which fixed the issue for the active state: 9f9aaa6

I will move this back to the CMS issue tracker.