Skip to content

Multilingual site - some variants always have pending changes #19376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
krebil opened this issue May 21, 2025 · 3 comments
Open

Multilingual site - some variants always have pending changes #19376

krebil opened this issue May 21, 2025 · 3 comments
Labels
state/needs-more-info We don't have enough information to give a good reply type/bug

Comments

@krebil
Copy link
Contributor

krebil commented May 21, 2025

Which Umbraco version are you using?

15.3.1

Bug summary

When I publish specific variants on some pages they always show pending changes after.

Specifics

I've disabled all my notification handlers and ensured my variant is published.

Image

I've been digging into what data it's using for comparison and it seems that
ByKeyPublishedDocumentController
ByKeyDocumentController
Return different ordering of values in nested blocklist items. I have not observed the same behaviour in block grid.

Image

Another thing that I have checked is that state doesn't update after a publish even when publish and update date matches

Image

It seems to also work the other way around where saving changes will result in published without pending changes on the non-main languges

Image

Adding a decorator to IDocumentPresentationFactory and artificially setting the correct edited state makes the UI render correctly

Steps to reproduce

It's been pretty difficult to reproduce on a fresh install. I think it happened after we changed our default language.

Expected result / actual result

No response

Copy link

Hi there @krebil!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

  • We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
  • If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
  • We'll replicate the issue to ensure that the problem is as described.
  • We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@NguyenThuyLan
Copy link
Contributor

Hi @krebil , it was hard to reproduce this issue without clear steps to reproduce. I tried on v16.1.0 and changed the default language, but I didn't see it. Could you please provide more details on this?

@NguyenThuyLan NguyenThuyLan added the state/needs-more-info We don't have enough information to give a good reply label May 22, 2025
@krebil
Copy link
Contributor Author

krebil commented May 22, 2025

I don't have specific steps, but I can probably share a database with limited content if that works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state/needs-more-info We don't have enough information to give a good reply type/bug
Projects
None yet
Development

No branches or pull requests

2 participants