return always PickedColor type | instance #19347
Closed
+5,523
−1,571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Mads Rasmussen <[email protected]>
Co-authored-by: Copilot <[email protected]>
umbraco#19267) Co-authored-by: Niels Lyngsø <[email protected]>
…mbraco#19284) Co-authored-by: Niels Lyngsø <[email protected]>
Co-authored-by: Niels Lyngsø <[email protected]>
… validate markup instead of JSON) (umbraco#19280)
…play of URLs (umbraco#19296) Co-authored-by: leekelleher <[email protected]>
* Deprecate the AuditService.Write() method It will be moved to a new service with the rework of the AuditService, as it relates to a different repository (umbracoLog vs umbracoAudit). * Update obsolete message to reference V18 * Apply suggestions from code review Co-authored-by: Kenn Jacobsen <[email protected]> --------- Co-authored-by: Kenn Jacobsen <[email protected]>
…ttings (umbraco#19291) * Allow segment access to editors with access to documents, not only settings. * Update src/Umbraco.Cms.Api.Management/Controllers/Segment/SegmentControllerBase.cs Co-authored-by: Kenn Jacobsen <[email protected]> * Cleaned up usings --------- Co-authored-by: Kenn Jacobsen <[email protected]>
* close dropdown workaround * Update dropdown.element.ts
* Updated language helper to use data mark * Bumped version
* make sure the unique follows the unique of the models type * make sure the uniques are used to clean up * omit #containers state for a more direct data flow * ensure containers are refreshed correctly * set ownerContentTypeUnique to undefined when clear
* Ensures cultures set on content are correctly cased and verifies with integration tests. * Improved test comments. * Move culture casing check into an extension method and use from content service. * Deduplicated test code and added more test cases * Only run invalid culture codes test on Windows --------- Co-authored-by: Kenn Jacobsen <[email protected]>
* add method to get all property aliases * pass property aliases to composition modal * put in a box + adjust spacing * disable if doc type is not compatible for composing * compare with what is used for composition * add comment --------- Co-authored-by: Niels Lyngsø <[email protected]>
* Updated nightly E2E pipeline * Fixed failing E2E tests * Skipped content tests wirh list view content due to an issue * Updated tests due to UI changes * Bumped version * Added more waits
* Added culture parameter to search APIs and propagated it to the indexed entity search service * Variant Culture aware search in Document and Media Pickers (umbraco#19336) * generate types * enable selection of entity-item-ref elements * Update input-document.element.ts * add culture to document search args * pass culture param to search end point * get variant context in document picker * add variant context * set culture in variant context when changing app language * set variant context when swithing variant in a workspace * Update content-detail-workspace-base.ts * clean up * remove from split view manager * Update property-dataset-base-context.ts * change name to fallbackCulture * simplify * get context instead of consuming * make all methods async * implement for media * Update current-user-action.extension.ts * allow null until we reach the server * remove log --------- Co-authored-by: Niels Lyngsø <[email protected]> * remove console.log * add display culture * opt-in inheritance * set observe alias to observeAppCulture * stop inheritance if specific cultures are set * remove unused import * include culture for document and media global search * await value for get methods * include orderCulture for document collections * Update document-collection.context.ts * Update document-collection.context.ts * fix self import --------- Co-authored-by: Niels Lyngsø <[email protected]> Co-authored-by: Mads Rasmussen <[email protected]>
Disabled SQLite tests and made it run against the release/16.0 branch
…-release # Conflicts: # Directory.Packages.props # build/nightly-E2E-test-pipelines.yml # src/Umbraco.Core/PropertyEditors/DataValueReferenceFactoryCollection.cs # src/Umbraco.Web.UI.Client/package-lock.json # src/Umbraco.Web.UI.Client/package.json # tests/Umbraco.Tests.AcceptanceTest/package-lock.json # tests/Umbraco.Tests.AcceptanceTest/package.json # tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/RichTextEditor/ContentWithTiptap.spec.ts # tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Media/Media.spec.ts # version.json
…d to refactor the test
…t has a nested array (umbraco#19363) * Fix for invalid state in JsonBlockValueConverter when an unused layout has a nested array * Improved comments as suggested by copilot review, also fixed code style miss * Added check for malformed JSON with more closing array tokens then opening tokens
* add slot for icon * expose icon data * render icon * load type for scaffold * rename * render icon for media * add observable for content type icon * request data in data source * wire up document scaffolding * remove unused * export server data source * render icon for member * rename data source to align with other detail sources * rename data source * remove unused styling * remove console log Co-authored-by: Copilot <[email protected]> * remove console log Co-authored-by: Copilot <[email protected]> * remove console log * Update detail-repository-base.ts * Update document-workspace-split-view.element.ts --------- Co-authored-by: Copilot <[email protected]>
Merged v15 dev to release 16
…release-to-main # Conflicts: # build/nightly-E2E-test-pipelines.yml # src/Umbraco.Web.UI.Client/eslint.config.js # src/Umbraco.Web.UI.Client/package-lock.json # src/Umbraco.Web.UI.Client/package.json # tests/Umbraco.Tests.AcceptanceTest/package-lock.json # tests/Umbraco.Tests.AcceptanceTest/package.json # tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/BlockGrid/VariantBlockGrid.spec.ts # tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/BlockList/VariantBlockList.spec.ts # tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentInfoTab.spec.ts # tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithCheckboxList.spec.ts # tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithDropdown.spec.ts # tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithMediaPicker.spec.ts # tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithRadiobox.spec.ts # tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithTextarea.spec.ts # tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithTextstring.spec.ts # tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/RedirectManagement.spec.ts # tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/RichTextEditor/ContentWithTiptap.spec.ts # tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/RichTextEditor/VariantTipTapBlocks.spec.ts # tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Dictionary/Dictionary.spec.ts # version.json
…-main Merged from release/16.0 to main branch
* also set manifest when using createExtensionApi() * set manifest when using createExtensionManifest
* fix filter * remove console log
…ing locking and audit steps and handling only the expected update properties (umbraco#19308)
…nse (umbraco#19361) Handle user id 0 (Unknown/System) when building content version response model `IUserIdKeyResolver.GetAsync` throws an exception when a user is not found. As user 0 does not really exist, the exception was being thrown. We now handle this scenario to return an empty reference.
|
Hi @idseefeld thanks for the PR, Ill have to talk to HQ about this one, given the breaking change. Why is it an issue returning string based on the setting vs the full model? Thanks |
|
Hi @Matthew-Wise, |
# Conflicts: # version.json
…ferent-types-for-Color-Picker-values
…different-types-for-Color-Picker-values
|
Hi @idseefeld Spoken to HQ and they agreed with change but felt it would need to wait until v17 given that 16 has had 3 RC's, I retargeted the branch, but as you can see its made a right mess of it! Would it be possible for you to recreate the work targeting v17/dev - I did find your commit - a8c19bf So hopefully its just a copy paste job. Sorry again! |
|
Hi @Matthew-Wise, I'll retarget the changes for v17/dev. |
idseefeld
deleted the
v16/bugfix/19341-ModelsBuilder-generates-different-types-for-Color-Picker-values
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
If there's an existing issue for this PR then this fixes
Description