Sort available composition folders #19373
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR ensures that composition folders in the picker modal are displayed in alphabetical order rather than the order in which they first appear in the API response.
- Added a
.sort()call to the list of unique folder paths. - Updated
UmbCompositionPickerModalElementto sort folder entries before mapping.
.../packages/content/content-type/modals/composition-picker/composition-picker-modal.element.ts
Outdated
Show resolved
Hide resolved
.../packages/content/content-type/modals/composition-picker/composition-picker-modal.element.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull Request Overview
This PR ensures composition folders in the picker modal are displayed in alphabetical order by grouping and then sorting folder paths.
- Replaced manual Set-based grouping with
Object.groupBy - Sorted folder path keys using
localeCompare - Updated mapping to produce
_compatibleCompositionsfrom sorted groups
Comments suppressed due to low confidence (1)
src/Umbraco.Web.UI.Client/src/packages/content/content-type/modals/composition-picker/composition-picker-modal.element.ts:119
- [nitpick] The parameter name
keyis generic; consider renaming it topathfor clarity, e.g.,.map(path => ({ path, compositions: grouped[path] })).
.map((key) => ({ path: key, compositions: grouped[key] }));
.../packages/content/content-type/modals/composition-picker/composition-picker-modal.element.ts
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
If there's an existing issue for this PR then this fixes #19327
Description
The API returns the list of available compositions for a certain content type, ordered alphabetically, but individually (not grouped by folder). The grouping is done in the FE, by doing a distinct on the folder "path", and then getting all the compositions relating to that path.
As such, the folders were ordered by the placement in which they first appeared in the non-grouped results, which was not relevant.
As a fix, I added a
.sort()to the folders.This element is shared by content types, media types and member types.
Testing
Example:
Before the fix
After the fix
