Skip to content

Commit 0c454e1

Browse files
authored
Merge pull request #10 from udibo/dev
Fix ErrorResponse.toJSON examples
2 parents 763a730 + 993a253 commit 0c454e1

File tree

4 files changed

+5
-12
lines changed

4 files changed

+5
-12
lines changed

.github/workflows/ci.yml

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -51,17 +51,10 @@ jobs:
5151
shell: bash
5252
run: |
5353
echo "RELEASE_VERSION=${GITHUB_REF/refs\/tags\//}" >> $GITHUB_ENV
54-
- name: Bundle
55-
if: env.RELEASE_VERSION != ''
56-
run: |
57-
mkdir -p target/release
58-
deno bundle mod.ts target/release/http-error.${RELEASE_VERSION}.js
5954
- name: Release
6055
uses: softprops/action-gh-release@v1
6156
if: env.RELEASE_VERSION != ''
6257
env:
6358
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
6459
with:
6560
draft: true
66-
files: |
67-
target/release/http-error.${{ env.RELEASE_VERSION }}.js

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -197,7 +197,7 @@ import { ErrorResponse, HttpError, isErrorResponse } from "@udibo/http-error";
197197

198198
async function getMovies() {
199199
const response = await fetch("https://example.com/movies.json");
200-
if (!response.ok) throw new ErrorResponse.toError(movies);
200+
if (!response.ok) throw await ErrorResponse.toError(response);
201201
return await response.json();
202202
}
203203
```
@@ -213,7 +213,7 @@ import { ErrorResponse, HttpError, isErrorResponse } from "@udibo/http-error";
213213
async function getMovies() {
214214
const response = await fetch("https://example.com/movies.json");
215215
const movies = await response.json();
216-
if (isErrorResponse(movies)) throw new ErrorResponse.toError(movies);
216+
if (isErrorResponse(movies)) throw ErrorResponse.toError(movies);
217217
if (response.status >= 400) {
218218
throw new HttpError(response.status, "Invalid response");
219219
}

deno.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@udibo/http-error",
3-
"version": "0.9.0",
3+
"version": "0.9.1",
44
"exports": {
55
".": "./mod.ts"
66
},

mod.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -466,7 +466,7 @@ export class ErrorResponse<
466466
*
467467
* async function getMovies() {
468468
* const response = await fetch("https://example.com/movies.json");
469-
* if (!response.ok) throw new ErrorResponse.toError(response);
469+
* if (!response.ok) throw await ErrorResponse.toError(response);
470470
* return await response.json();
471471
* }
472472
* ```
@@ -482,7 +482,7 @@ export class ErrorResponse<
482482
* async function getMovies() {
483483
* const response = await fetch("https://example.com/movies.json");
484484
* const movies = await response.json();
485-
* if (isErrorResponse(movies)) throw new ErrorResponse.toError(movies);
485+
* if (isErrorResponse(movies)) throw ErrorResponse.toError(movies);
486486
* if (response.status >= 400) {
487487
* throw new HttpError(response.status, "Invalid response");
488488
* }

0 commit comments

Comments
 (0)