Capture expected 'FATAL' output from tag check

Author: nwiltsie

bumpchanges/getversion.py

@@ -44,18 +44,18 @@ def get_next_version():
     logger.notice("New version (tag): %s (%s)", next_version, next_tag)
 
     # Confirm that the corresponding git tag does not exist
-    try:
-        tag_ref = subprocess.check_output(
-            ["git", "rev-parse", "--verify", f"refs/tags/{next_tag}"],
-            cwd=repo_dir
-        )
+    tag_ref_proc = subprocess.run(
+        ["git", "rev-parse", "--verify", f"refs/tags/{next_tag}"],
+        cwd=repo_dir,
+        capture_output=True,
+        check=False,
+    )
+    if tag_ref_proc.returncode == 0:
         # Oops, that tag does exist
-        logger.error("Tag %s already exists! %s", next_tag, tag_ref)
+        logger.error(
+            "Tag %s already exists! %s", next_tag, tag_ref_proc.stdout.decode("utf-8")
+        )
         raise RuntimeError()
 
-    except subprocess.CalledProcessError:
-        # Tag doesn't exist yet - everything is good!
-        pass
-
     with output_file.open(mode="w", encoding="utf-8") as outfile:
         outfile.write(f"next_version={next_version}\n")

bumpchanges/logging.py

@@ -1,4 +1,5 @@
 "Module to handle logging to GitHub Actions."
+
 import logging
 
 
@@ -7,21 +8,22 @@
 
 class NoticeLogger(logging.getLoggerClass()):
     "A logger subclass that has an additional NOTICE level."
+
     def notice(self, msg, *args, **kwargs):
         "Log the message at NOTICE level."
         self.log(NOTICE, msg, *args, **kwargs)
 
 
 class GHAFilter(logging.Filter):
     "A logging filter that plays nice with GitHub Actions output."
+
     prefixes = {
         logging.DEBUG: "::debug::",
         logging.INFO: "",
         NOTICE: "::notice::",
         logging.WARNING: "::warning::",
         logging.ERROR: "::error::",
         logging.CRITICAL: "::error::",
-
     }
 
     def filter(self, record):
@@ -45,6 +47,6 @@ def setup_logging():
     handler.addFilter(GHAFilter())
 
     # Set these handlers on the root logger of this module
-    root_logger = logging.getLogger(__name__.rpartition('.')[0])
+    root_logger = logging.getLogger(__name__.rpartition(".")[0])
     root_logger.addHandler(handler)
     root_logger.setLevel(logging.DEBUG)