Skip to content

Commit 4b8bad4

Browse files
committed
Fix user switcher overflow
Overflow scroll elements doesn't play well with overflowing children with position anything but static: twbs/bootstrap#24251 Fix by padding with spacer div since user switcher has a known maximum height.
1 parent 2433ef4 commit 4b8bad4

File tree

2 files changed

+10
-4
lines changed

2 files changed

+10
-4
lines changed

app/styles/app.scss

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -213,3 +213,7 @@ html {
213213
margin-top: 100px;
214214
width: 300px;
215215
}
216+
217+
.user-switcher-spacer {
218+
height: map-get($spacers, 4) * 3;
219+
}

app/templates/admin/index.hbs

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -252,8 +252,8 @@ as |form|
252252
</table>
253253
</div>
254254
</div>
255-
{{#if (gt model.meta.pagination.pages 1)}}
256-
<div class="row">
255+
<div class="row">
256+
{{#if (gt model.meta.pagination.pages 1)}}
257257
<div class="col-12 d-flex justify-content-center">
258258
{{bs4-paginator
259259
navAreaLabelText="Orders pagination"
@@ -268,6 +268,8 @@ as |form|
268268
}}
269269
{{! TODO rename => onPageChange}}
270270
</div>
271-
</div>
272-
{{/if}}
271+
{{else}}
272+
<div class="col-12 user-switcher-spacer"></div>
273+
{{/if}}
274+
</div>
273275
{{outlet}}

0 commit comments

Comments
 (0)