Skip to content

Commit 9c23ed4

Browse files
authored
[AUTO][FILECONTROL] - version 133.0.6943.60 (#1780)
[AUTO][FILECONTROL] - version 133.0.6943.60
2 parents 3a7040d + 8950c1c commit 9c23ed4

File tree

328 files changed

+5446
-5818
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

328 files changed

+5446
-5818
lines changed

tools/under-control/src/RELEASE

+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
132.0.6834.163
1+
133.0.6943.60

tools/under-control/src/android_webview/browser/aw_content_browser_client.cc

+5-28
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222
#include "android_webview/browser/aw_contents_io_thread_client.h"
2323
#include "android_webview/browser/aw_cookie_access_policy.h"
2424
#include "android_webview/browser/aw_devtools_manager_delegate.h"
25-
#include "android_webview/browser/aw_enterprise_helper.h"
2625
#include "android_webview/browser/aw_feature_list_creator.h"
2726
#include "android_webview/browser/aw_http_auth_handler.h"
2827
#include "android_webview/browser/aw_settings.h"
@@ -112,7 +111,6 @@
112111
#include "mojo/public/cpp/bindings/pending_receiver.h"
113112
#include "net/android/network_library.h"
114113
#include "net/cookies/site_for_cookies.h"
115-
#include "net/dns/public/secure_dns_mode.h"
116114
#include "net/http/http_util.h"
117115
#include "net/net_buildflags.h"
118116
#include "net/ssl/ssl_cert_request_info.h"
@@ -286,29 +284,6 @@ void AwContentBrowserClient::OnNetworkServiceCreated(
286284
network_service->SetUpHttpAuth(network::mojom::HttpAuthStaticParams::New());
287285
network_service->ConfigureHttpAuthPrefs(
288286
AwBrowserProcess::GetInstance()->CreateHttpAuthDynamicParams());
289-
290-
if (base::FeatureList::IsEnabled(features::kWebViewAsyncDns)) {
291-
enterprise::GetEnterpriseState(
292-
base::BindOnce([](enterprise::EnterpriseState state) {
293-
switch (state) {
294-
case enterprise::EnterpriseState::kUnknown:
295-
// If we cannot be certain about the enterprise state, we should
296-
// not enable the AsyncDNS resolver, but fall back on the system
297-
// resolver.
298-
case enterprise::EnterpriseState::kEnterpriseOwned:
299-
// On enterprise owned devices, we should use the system resolver
300-
// to make sure that we respect any network settings implemented
301-
// by the device owner.
302-
return;
303-
case enterprise::EnterpriseState::kNotOwned:
304-
content::GetNetworkService()->ConfigureStubHostResolver(
305-
/*insecure_dns_client_enabled=*/true,
306-
net::SecureDnsMode::kAutomatic, net::DnsOverHttpsConfig(),
307-
/*additional_dns_types_enabled=*/true);
308-
break;
309-
}
310-
}));
311-
}
312287
}
313288

314289
void AwContentBrowserClient::ConfigureNetworkContextParams(
@@ -364,7 +339,7 @@ void AwContentBrowserClient::RenderProcessWillLaunch(
364339
// per-view access checks, and access is granted by default (see
365340
// AwSettings.mAllowContentUrlAccess).
366341
content::ChildProcessSecurityPolicy::GetInstance()->GrantRequestScheme(
367-
host->GetID(), url::kContentScheme);
342+
host->GetDeprecatedID(), url::kContentScheme);
368343
}
369344

370345
bool AwContentBrowserClient::IsExplicitNavigation(
@@ -724,7 +699,8 @@ AwContentBrowserClient::CreateURLLoaderThrottles(
724699
/* hash_realtime_service */ nullptr,
725700
/* hash_realtime_selection */
726701
hash_real_time_selection,
727-
/* async_check_tracker */ async_check_tracker));
702+
/* async_check_tracker */ async_check_tracker,
703+
/*referring_app_info=*/std::nullopt));
728704

729705
if (request.destination == network::mojom::RequestDestination::kDocument) {
730706
const bool is_load_url =
@@ -772,7 +748,7 @@ AwContentBrowserClient::CreateURLLoaderThrottlesForKeepAlive(
772748
/* hash_realtime_service */ nullptr,
773749
/* hash_realtime_selection */
774750
hash_real_time_selection,
775-
/* async_check_tracker */ nullptr));
751+
/* async_check_tracker */ nullptr, /*referring_app_info=*/std::nullopt));
776752

777753
return result;
778754
}
@@ -896,6 +872,7 @@ AwContentBrowserClient::CreateLoginDelegate(
896872
const GURL& url,
897873
scoped_refptr<net::HttpResponseHeaders> response_headers,
898874
bool first_auth_attempt,
875+
content::GuestPageHolder* guest,
899876
LoginAuthRequiredCallback auth_required_callback) {
900877
return std::make_unique<AwHttpAuthHandler>(auth_info, web_contents,
901878
first_auth_attempt,

tools/under-control/src/android_webview/browser/aw_field_trials.cc

+45-62
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,6 @@
99
#include "base/allocator/partition_alloc_features.h"
1010
#include "base/base_paths_android.h"
1111
#include "base/check.h"
12-
#include "base/feature_list.h"
13-
#include "base/memory/raw_ref.h"
14-
#include "base/metrics/field_trial.h"
1512
#include "base/metrics/field_trial_params.h"
1613
#include "base/metrics/persistent_histogram_allocator.h"
1714
#include "base/path_service.h"
@@ -32,66 +29,47 @@
3229
#include "ui/android/ui_android_features.h"
3330
#include "ui/gl/gl_features.h"
3431

35-
namespace {
32+
namespace internal {
3633

37-
class AwFeatureOverrides {
38-
public:
39-
explicit AwFeatureOverrides(base::FeatureList& feature_list)
40-
: feature_list_(feature_list) {}
34+
AwFeatureOverrides::AwFeatureOverrides(base::FeatureList& feature_list)
35+
: feature_list_(feature_list) {}
4136

42-
AwFeatureOverrides(const AwFeatureOverrides& other) = delete;
43-
AwFeatureOverrides& operator=(const AwFeatureOverrides& other) = delete;
44-
45-
~AwFeatureOverrides() {
46-
for (const auto& field_trial_override : field_trial_overrides_) {
47-
feature_list_->RegisterFieldTrialOverride(
48-
field_trial_override.feature->name,
49-
field_trial_override.override_state,
50-
field_trial_override.field_trial);
51-
}
52-
feature_list_->RegisterExtraFeatureOverrides(std::move(overrides_));
53-
}
54-
55-
// Enable a feature with WebView-specific override.
56-
void EnableFeature(const base::Feature& feature) {
57-
overrides_.emplace_back(
58-
std::cref(feature),
59-
base::FeatureList::OverrideState::OVERRIDE_ENABLE_FEATURE);
60-
}
61-
62-
// Disable a feature with WebView-specific override.
63-
void DisableFeature(const base::Feature& feature) {
64-
overrides_.emplace_back(
65-
std::cref(feature),
66-
base::FeatureList::OverrideState::OVERRIDE_DISABLE_FEATURE);
37+
AwFeatureOverrides::~AwFeatureOverrides() {
38+
// TODO(crbug.com/379864779): This doesn't play well with potential server-
39+
// side overrides.
40+
for (const auto& field_trial_override : field_trial_overrides_) {
41+
feature_list_->RegisterFieldTrialOverride(
42+
field_trial_override.feature->name, field_trial_override.override_state,
43+
field_trial_override.field_trial);
6744
}
45+
feature_list_->RegisterExtraFeatureOverrides(
46+
std::move(overrides_), /*replace_use_default_overrides=*/true);
47+
}
6848

69-
// Enable or disable a feature with a field trial. This can be used for
70-
// setting feature parameters.
71-
void OverrideFeatureWithFieldTrial(
72-
const base::Feature& feature,
73-
base::FeatureList::OverrideState override_state,
74-
base::FieldTrial* field_trial) {
75-
field_trial_overrides_.emplace_back(FieldTrialOverride{
76-
.feature = raw_ref(feature),
77-
.override_state = override_state,
78-
.field_trial = field_trial,
79-
});
80-
}
49+
void AwFeatureOverrides::EnableFeature(const base::Feature& feature) {
50+
overrides_.emplace_back(
51+
std::cref(feature),
52+
base::FeatureList::OverrideState::OVERRIDE_ENABLE_FEATURE);
53+
}
8154

82-
private:
83-
struct FieldTrialOverride {
84-
raw_ref<const base::Feature> feature;
85-
base::FeatureList::OverrideState override_state;
86-
raw_ptr<base::FieldTrial> field_trial;
87-
};
55+
void AwFeatureOverrides::DisableFeature(const base::Feature& feature) {
56+
overrides_.emplace_back(
57+
std::cref(feature),
58+
base::FeatureList::OverrideState::OVERRIDE_DISABLE_FEATURE);
59+
}
8860

89-
base::raw_ref<base::FeatureList> feature_list_;
90-
std::vector<base::FeatureList::FeatureOverrideInfo> overrides_;
91-
std::vector<FieldTrialOverride> field_trial_overrides_;
92-
};
61+
void AwFeatureOverrides::OverrideFeatureWithFieldTrial(
62+
const base::Feature& feature,
63+
base::FeatureList::OverrideState override_state,
64+
base::FieldTrial* field_trial) {
65+
field_trial_overrides_.emplace_back(FieldTrialOverride{
66+
.feature = raw_ref(feature),
67+
.override_state = override_state,
68+
.field_trial = field_trial,
69+
});
70+
}
9371

94-
} // namespace
72+
} // namespace internal
9573

9674
void AwFieldTrials::OnVariationsSetupComplete() {
9775
// Persistent histograms must be enabled ASAP, but depends on Features.
@@ -109,7 +87,7 @@ void AwFieldTrials::RegisterFeatureOverrides(base::FeatureList* feature_list) {
10987
if (!feature_list) {
11088
return;
11189
}
112-
AwFeatureOverrides aw_feature_overrides(*feature_list);
90+
internal::AwFeatureOverrides aw_feature_overrides(*feature_list);
11391

11492
// Disable third-party storage partitioning on WebView.
11593
aw_feature_overrides.DisableFeature(
@@ -143,7 +121,6 @@ void AwFieldTrials::RegisterFeatureOverrides(base::FeatureList* feature_list) {
143121

144122
// Disable Shared Storage on WebView.
145123
aw_feature_overrides.DisableFeature(blink::features::kSharedStorageAPI);
146-
aw_feature_overrides.DisableFeature(blink::features::kSharedStorageAPIM125);
147124

148125
// Disable scrollbar-color on WebView.
149126
aw_feature_overrides.DisableFeature(blink::features::kScrollbarColor);
@@ -247,6 +224,13 @@ void AwFieldTrials::RegisterFeatureOverrides(base::FeatureList* feature_list) {
247224
aw_feature_overrides.DisableFeature(
248225
blink::features::kIncrementLocalSurfaceIdForMainframeSameDocNavigation);
249226

227+
// Disabling this feature for WebView, since it can switch focus when scrolled
228+
// in cases with multiple views which can trigger HTML focus changes that
229+
// aren't intended. See crbug.com/378779896, crbug.com/373672168 for more
230+
// details.
231+
aw_feature_overrides.DisableFeature(
232+
::features::kFocusRenderWidgetHostViewAndroidOnActionDown);
233+
250234
if (base::CommandLine::ForCurrentProcess()->HasSwitch(switches::kDebugBsa)) {
251235
// Feature parameters can only be set via a field trial.
252236
const char kTrialName[] = "StudyDebugBsa";
@@ -289,10 +273,6 @@ void AwFieldTrials::RegisterFeatureOverrides(base::FeatureList* feature_list) {
289273
// WebView.
290274
aw_feature_overrides.DisableFeature(::features::kDIPS);
291275

292-
// TODO(crbug.com/41492947): See crrev.com/c/5744034 for details, but I was
293-
// unable to add this feature to fieldtrial_testing_config and pass all tests.
294-
aw_feature_overrides.EnableFeature(blink::features::kElementGetInnerHTML);
295-
296276
// These features have shown performance improvements in WebView but not some
297277
// other platforms.
298278
aw_feature_overrides.EnableFeature(features::kEnsureExistingRendererAlive);
@@ -309,4 +289,7 @@ void AwFieldTrials::RegisterFeatureOverrides(base::FeatureList* feature_list) {
309289
// WebView.
310290
aw_feature_overrides.DisableFeature(
311291
base::features::kPartitionAllocMemoryTagging);
292+
293+
// Disable Topics on WebView.
294+
aw_feature_overrides.DisableFeature(blink::features::kBrowsingTopics);
312295
}

tools/under-control/src/chrome/android/java/AndroidManifest.xml

+17-3
Original file line numberDiff line numberDiff line change
@@ -948,7 +948,13 @@ by a child template that "extends" this file.
948948
android:excludeFromRecents="true"
949949
android:windowSoftInputMode="adjustResize"
950950
android:configChanges="orientation|keyboardHidden|keyboard|screenSize|mcc|mnc|screenLayout|smallestScreenSize|uiMode"
951-
android:hardwareAccelerated="false" />
951+
android:hardwareAccelerated="false">
952+
<intent-filter>
953+
<action android:name="android.intent.action.WEB_SEARCH" />
954+
<!-- Permits Chrome to act as a default handler for WEB_SEARCH intents. -->
955+
<category android:name="android.intent.category.DEFAULT" />
956+
</intent-filter>
957+
</activity>
952958

953959
<!-- GcmTaskService for registration for Invalidations. Not actually implemented anymore. -->
954960
<service android:name="com.google.ipc.invalidation.ticl.android2.channel.GcmRegistrationTaskService"
@@ -1088,9 +1094,10 @@ by a child template that "extends" this file.
10881094

10891095
<!-- Activities for task manager. -->
10901096
<activity
1091-
android:name="org.chromium.chrome.browser.task_manager.TaskManagerActivity"
1097+
android:name="org.chromium.chrome.browser.task_manager.ui.TaskManagerActivity"
10921098
android:exported="false"
1093-
android:theme="@style/Theme.Chromium.Activity">
1099+
android:theme="@style/Theme.Chromium.Activity"
1100+
android:launchMode="singleInstance">
10941101
</activity>
10951102

10961103
<receiver android:name="org.chromium.chrome.browser.notifications.scheduler.DisplayAgent$Receiver"
@@ -1335,6 +1342,13 @@ by a child template that "extends" this file.
13351342
android:readPermission="android.permission.GLOBAL_SEARCH" />
13361343
</provider>
13371344

1345+
<provider
1346+
android:name="org.chromium.chrome.browser.provider.PageContentProvider"
1347+
android:authorities="{{ manifest_package }}.PageContentProvider"
1348+
android:exported="false"
1349+
android:grantUriPermissions="true">
1350+
</provider>
1351+
13381352
{% block base_application_definitions %}
13391353
{% endblock %}
13401354
{% block extra_application_definitions_for_test %}

0 commit comments

Comments
 (0)