Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invert Preview not actually inverting preview in some cases #570

Open
noshea opened this issue Mar 5, 2025 · 0 comments
Open

Invert Preview not actually inverting preview in some cases #570

noshea opened this issue Mar 5, 2025 · 0 comments
Labels
bug Something isn't working.

Comments

@noshea
Copy link

noshea commented Mar 5, 2025

Description

Context
File was newly created shortly before issue was experienced. Occurred in both Windows 10 Pro in Firefox (first-time user) and Arch Linux in Firefox (existing user but had never used Invert Preview).

Primary bug

View > Theme > Dark --> editor switches to dark mode (as expected)
View > Theme > Invert Preview --> nothing happens (expected to turn dark)
View > Theme > Invert Preview --> nothing happens

View > Theme > System --> editor stays light mode (as expected)
View > Theme > Invert Preview --> nothing happens (expected to turn dark)
View > Theme > Invert Preview --> nothing happens

View > Theme > Dark --> editor switches to dark mode
View > Theme > Invert Preview --> nothing happens
Show Preview in Popup --> preview opens in new window in dark mode
Close Popup --> preview remains in dark mode in split-screen
After this, the theme seems to consistently correctly shift even when the preview is opened, closed, or moved to pop-up, even when switching between modes with Invert Preview on or off

If the theme is set to Dark and the browser refreshed, Invert Preview seems to work as expected.

However, if the theme is set to Light or System (when the system default is Light) and the browser refreshed, Invert Preview again stops working. To make it work again, must again set theme to Dark, Open preview in popup, and Invert Theme

Secondary related bug

In Light mode, there is no ability to Invert Theme. However, if the preview is set to Dark mode already and theme is turned back to Light, the preview remains dark with no way to invert without reloading the browser or changing back to Dark, toggling Invert Theme, and changing back to Light again.

However, if the browser is reloaded, going back into the View menu and setting Theme to Dark still shows Invert Theme as selected even though both editor and preview display in light mode, yet toggling this option on and off now does nothing again (since browser was reloaded again).

Suggested resolution

Ditch "Invert Preview." Make two distinct submenus with options for editor and preview, i.e.:
View > Editor theme > Light, Dark, System [choose one]
View > Preview theme > Light, Dark, System [choose one]

Reproduction URL

No response

Browsers

Firefox

OS

Windows

@noshea noshea added the bug Something isn't working. label Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working.
Projects
None yet
Development

No branches or pull requests

1 participant