Skip to content

Commit a01e933

Browse files
committed
housekeeping
1 parent 3bc2d25 commit a01e933

File tree

5 files changed

+51
-44
lines changed

5 files changed

+51
-44
lines changed

codeForDoc/package.json

+13-14
Original file line numberDiff line numberDiff line change
@@ -15,23 +15,22 @@
1515
"dependencies": {
1616
"code-for-doc": "file:",
1717
"firebase-admin": "latest",
18-
"firelord": "^2.3.1"
18+
"firelord": "^2.3.10"
1919
},
2020
"devDependencies": {
21-
"@types/lodash": "^4.14.180",
22-
"@typescript-eslint/eslint-plugin": "^5.0.0",
23-
"@typescript-eslint/parser": "^5.0.0",
24-
"@vitest/coverage-c8": "^0.28.4",
25-
"dotenv": "^16.0.1",
26-
"eslint": "^7.32.0",
21+
"@typescript-eslint/eslint-plugin": "^5.56.0",
22+
"@typescript-eslint/parser": "^5.56.0",
23+
"@vitest/coverage-c8": "^0.29.7",
24+
"dotenv": "^16.0.3",
25+
"eslint": "^8.36.0",
2726
"eslint-cli": "^1.1.1",
28-
"eslint-config-prettier": "^8.3.0",
29-
"eslint-import-resolver-typescript": "^2.5.0",
30-
"eslint-plugin-import": "^2.25.2",
31-
"eslint-plugin-prettier": "^4.0.0",
27+
"eslint-config-prettier": "^8.8.0",
28+
"eslint-import-resolver-typescript": "^3.5.3",
29+
"eslint-plugin-import": "^2.27.5",
30+
"eslint-plugin-prettier": "^4.2.1",
3231
"kill-port": "^2.0.1",
33-
"prettier": "^2.4.1",
34-
"typescript": "^4.8.2",
35-
"vitest": "^0.28.4"
32+
"prettier": "^2.8.6",
33+
"typescript": "^5.0.2",
34+
"vitest": "^0.29.7"
3635
}
3736
}

codeForDoc/src/highlights/whereFirelord.ts

-16
Original file line numberDiff line numberDiff line change
@@ -53,19 +53,3 @@ type ABC = MetaTypeCreator<
5353
>
5454

5555
const ColRef = getFirelord<ABC>(db, 'ABC').collection()
56-
57-
// literal type
58-
query(ColRef, where('a', '>', 1)) // ok, not dealing with array
59-
// @ts-expect-error
60-
query(ColRef, where('a', 'in', [1])) // not ok, it is an array AND literal type, need const assertion!
61-
query(ColRef, where('a', 'in', [1 as const])) // ok, const assertion!
62-
query(ColRef, where('a', 'in', [1] as const)) // ok, const assertion!
63-
64-
// literal array type
65-
// @ts-expect-error
66-
query(ColRef, where('b', '==', ['a'])) // not ok, dealing with array AND literal type, need const assertion!
67-
query(ColRef, where('b', '==', ['a' as const])) // ok, const assertion!
68-
query(ColRef, where('b', 'in', [['a' as const]])) // ok, const assertion!
69-
query(ColRef, where('b', '==', ['a'] as const)) // ok, const assertion!
70-
query(ColRef, where('b', 'in', [['a'] as const])) // ok, const assertion!
71-
query(ColRef, where('b', 'in', [['a']] as const)) // ok, const assertion!

package-lock.json

+37-11
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@
9191
"pick-random": "^4.0.0",
9292
"prettier": "^2.8.6",
9393
"pretty-quick": "^3.1.3",
94-
"rollup": "^3.20.0",
94+
"rollup": "^2.79.1",
9595
"rollup-plugin-terser": "^7.0.2",
9696
"shelljs": "^0.8.5",
9797
"tsdoc": "^0.0.4",

src/queryClauses/where.test.ts

-2
Original file line numberDiff line numberDiff line change
@@ -88,8 +88,6 @@ describe('test query ref', () => {
8888
it('test literal type without const assertion, should pass', () => {
8989
query(ref, where('role', 'in', ['admin']))
9090
query(ref, where('role', 'not-in', ['admin']))
91-
query(ref, where('role', 'in', ['admin']))
92-
query(ref, where('role', 'not-in', ['admin']))
9391
})
9492
it('test block fresh empty array, negative case', () => {
9593
// @ts-expect-error

0 commit comments

Comments
 (0)