Skip to content

Remove dependency on tree-sitter-nickel #1022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Xophmeister opened this issue Jun 2, 2025 · 0 comments
Open

Remove dependency on tree-sitter-nickel #1022

Xophmeister opened this issue Jun 2, 2025 · 0 comments

Comments

@Xophmeister
Copy link
Member

Xophmeister commented Jun 2, 2025

tree-sitter-nickel is a declared dependency in Cargo.toml, but it is only used in the [little-used] benchmark testing (topiary-core/benches/benchmark.rs). This benchmark was written before dynamic loading was implemented and, while we don't want to benchmark the dynamic loading -- as it can involve a download-and-build step -- we could still make use of this mechanism.

This would remove the dependency on tree-sitter-nickel and make topiary-config/languages.ncl the authoritative source.

(For a similar discussion for tree-sitter-json, see #1023.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant