Skip to content

Table borders look bad in dark mode #35982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 tasks done
j-f1 opened this issue Mar 9, 2022 · 3 comments
Closed
3 tasks done

Table borders look bad in dark mode #35982

j-f1 opened this issue Mar 9, 2022 · 3 comments

Comments

@j-f1
Copy link

j-f1 commented Mar 9, 2022

Prerequisites

Describe the issue

I’m super excited to see #35857 and have built a copy of it to try out on my website. However, in dark mode, the borders of table cells remain black (or dark gray).

I think the best solution here would be to update the default .table class to use --bs-border-color as its border color, then add a new class (table-white?) that continues to use the current border colors, but also adds an explicit white background to table cells.

Reduced test cases

See the docs for tables: https://deploy-preview-35857--twbs-bootstrap.netlify.app/docs/5.1/content/tables/

Screenshot_2022-03-09 16 11 06

In light mode, the very first table looks good. But in dark mode, its borders do not change color.

What operating system(s) are you seeing the problem on?

macOS

What browser(s) are you seeing the problem on?

Safari

What version of Bootstrap are you using?

3790ed0

@mdo
Copy link
Member

mdo commented Mar 9, 2022

Yeah, there's going to be a ton that's incomplete there—nearly all components aren't ready for it yet. No need to report issues on that branch/PR just yet :).

@mdo mdo closed this as completed Mar 9, 2022
@j-f1
Copy link
Author

j-f1 commented Mar 9, 2022

Sounds good! I only reported it because I saw no other issues with my (admittedly not super complex) website.

@mdo
Copy link
Member

mdo commented Mar 10, 2022

All good! Appreciate the extra eyes on it :). I'm very excited to see it evolve and improve!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants