Skip to content

Add an explaining comment to durationPadding for executeAfterTransition. #34168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
alpadev opened this issue Jun 2, 2021 · 1 comment
Closed

Add an explaining comment to durationPadding for executeAfterTransition. #34168

alpadev opened this issue Jun 2, 2021 · 1 comment
Labels
js p4 Low priority, nice to have stale Closed as stale v5

Comments

@alpadev
Copy link
Contributor

alpadev commented Jun 2, 2021 •
edited
Loading

Although the comment was not present here before, 5 seems the magic number here thus it is better to put a nice comment 🙂

Originally posted by @rohit2sharma95 in #33845 (comment)
@alpadev alpadev added js p3 Medium priority, and does not prevent the core functionality v5 p4 Low priority, nice to have and removed p3 Medium priority, and does not prevent the core functionality labels Jun 2, 2021
@alpadev
Copy link
Contributor Author

alpadev commented Jun 2, 2021 •
edited
Loading

@Johann-S maybe you can help with this, as the original implementation was done by you. Is this only to make sure that setTimeout will execute after an expected transitionend event?

@mdo mdo added the stale Closed as stale label Apr 10, 2025
@mdo mdo closed this as not planned Won't fix, can't repro, duplicate, stale Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
js p4 Low priority, nice to have stale Closed as stale v5
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mdo @alpadev