Skip to content

_custom.scss file missing in sass-bootstrap #23917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vikrantnegi opened this issue Sep 11, 2017 · 3 comments
Closed

_custom.scss file missing in sass-bootstrap #23917

vikrantnegi opened this issue Sep 11, 2017 · 3 comments
Labels

Comments

@vikrantnegi
Copy link

I download the Bootstrap v4.0 beta source files which includes the Bootstrap scss folder.

In the file _variables.scss it is mentioned in comments to copy the setting into the provided '_custom.scss' file to override the defaults but there is no such file in the downloaded folder.

// Variables
//
// Copy settings from this file into the provided `_custom.scss` to override
// the Bootstrap defaults without modifying key, versioned files.

Do we need to create that file ourselves or it should be provided in the download as well?

Thanks.

@Johann-S
Copy link
Member

IMO it's your choice to create that file or not, but we shouldn't share this file because some users don't want that file

@andresgalante
Copy link
Collaborator

andresgalante commented Sep 11, 2017

That's true, you wouldn't want an empty file on bootstrap.scss.

@Johann-S That comment is no longer on _variables.scss:
https://github.com/twbs/bootstrap/blame/v4-dev/scss/_variables.scss

@mdo
Copy link
Member

mdo commented Sep 13, 2017

No more custom Sass file and no more comment from our end, so closing out.

@mdo mdo closed this as completed Sep 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants