Skip to content

Wrong Color in Popover Arrow #22432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
IdanCo opened this issue Apr 13, 2017 · 3 comments
Closed

Wrong Color in Popover Arrow #22432

IdanCo opened this issue Apr 13, 2017 · 3 comments

Comments

@IdanCo
Copy link
Contributor

IdanCo commented Apr 13, 2017

When popover direction is set to bottom, the arrow has the wrong color:

image

Couldn't find any related PRs, i'll push one soon...

@Johann-S
Copy link
Member

Closed by : #22433

@IdanCo
Copy link
Contributor Author

IdanCo commented Apr 13, 2017

@Johann-S , the plot thickens -

After further research, I'm assuming the reason for the mixup with the color variable was intended to handle cases where the popover has a title:
image

The problem was that it affected all bottom-popovers, even those without a title.

This conflict can be solved by using the already existing title::before element to "cover" the existing arrow with the right color. I can quickly wrap a PR with this solution and let you decide what's best. What do you think?

@Johann-S
Copy link
Member

Oh nice catch I didn't know that. Yeah sure create your PR but this time I'll CC @mdo because I don't know all the use case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants