Skip to content

add min-width to container #18746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Nemo64 opened this issue Jan 1, 2016 · 5 comments
Closed

add min-width to container #18746

Nemo64 opened this issue Jan 1, 2016 · 5 comments
Labels

Comments

@Nemo64
Copy link

Nemo64 commented Jan 1, 2016

The grid can currently be pushed to 1px width. This probably does not happen in the wild and can only be accomplished using dev tools, however it probably wouldn't hurt to define an absolute minimum size for the grid system so that it is impossible to get an untested broken layout because the viewport width was too small.

I suggest 320px min-width on the container as this is the width of the iphone <= 5. Also, according to these stats, there is nothing smaller.

@cvrebert
Copy link
Collaborator

cvrebert commented Jan 2, 2016

X-Ref: #10513, #13221

These docs and this SO entry suggest that 240x320 physical px [as opposed to CSS px] is the de facto minimum Android screen size. (Although this neglects market share considerations, etc.)

@cvrebert cvrebert mentioned this issue Jan 2, 2016
17 tasks
@cvrebert cvrebert changed the title suggestion: add min-width to container add min-width to container Jan 2, 2016
@Nemo64
Copy link
Author

Nemo64 commented Jan 2, 2016

There is even a browser for android wear out there. I don't know how relevant those smaller screen sizes are. My idea is: if a site isn't optimized for these screens they'll look broken. With a min-width in place there will have to scroll horizontally but the layout would probably be fine.

@patrickhlauke
Copy link
Member

browser/OS/device manufacturers set their ideal viewport (what you get when doing width=device-width) to whatever they think gives them/their users the most comfortable experience. they also (generally) don't release a browser/OS/device which would make a large portion of sites look immediately unusable and broken. with that in mind, i'd be against defining a minimum width - once below a certain size sure, drop to single column. beyond that, i'd leave it up to authors to weigh up themselves if they're happy for their designs to scale down to ever decreasing widths (provided that their stuff is fluid). if devs then DO want to make a mininum cut-off, they can add it in themselves.

@mdo
Copy link
Member

mdo commented Jan 2, 2016

Not going to be adding this—v3 managed without it for the last 2.5 years so should be fine :).

@mdo mdo closed this as completed Jan 2, 2016
@pranav9196
Copy link

pranav9196 commented Oct 10, 2017

@mdo I have been looking for a fix to the xs-1 xs-11 wrap issue since the past two days and all I found is people saying that this is unrealistic and highly improbable layout usage, which is wrong, people can avoid this for sure but there should be a workaround to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants