Skip to content

.container, .container-fluid should be conditional upon $enable-grid-classes #17586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mmjaeger opened this issue Sep 13, 2015 · 1 comment
Closed

.container, .container-fluid should be conditional upon $enable-grid-classes #17586

mmjaeger opened this issue Sep 13, 2015 · 1 comment
Labels
css v4
Milestone
v4.0.0-alpha.3

Comments

@mmjaeger
Copy link

I'm actually wondering why you guys didn't put .container and .container-fluid not into the $enable-grid-classes condition - if I'm using the container mixin I don't need those container classes be created?
@cvrebert cvrebert changed the title grid.scss - .container, .container-fluid .container, .container-fluid should be conditional upon $enable-grid-classes Sep 13, 2015
@mdo mdo mentioned this issue Dec 8, 2015
Closed
17 tasks
@bassjobsen bassjobsen mentioned this issue Dec 26, 2015
Merged
@mdo mdo added this to the v4.0.0-alpha.3 milestone Jan 6, 2016
@mdo
Copy link
Member

mdo commented Jan 6, 2016

Fixed in #18695.

@mdo mdo closed this as completed Jan 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
css v4
Projects
None yet
Milestone
v4.0.0-alpha.3
Development

No branches or pull requests
3 participants
@mdo @cvrebert @mmjaeger