Skip to content

Removing max-width:100% from tables. #13706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bcullman opened this issue May 29, 2014 · 1 comment
Closed

Removing max-width:100% from tables. #13706

bcullman opened this issue May 29, 2014 · 1 comment
Labels
Milestone

Comments

@bcullman
Copy link
Contributor

From the history, it appears max-width was added to tables.less when various css declarations originating in reset.less were relocated to appropriate less files so that reset.less could be removed in favor of normalize.less.

However, this max-width declaration did not come from Eric Meyer's reset.less. Instead, it was added in the following check-in by @mdo "help tables not look like shit on mobile maybe?"

I dont believe that this declaration has proven it helps layouts on mobile. however it does cause layout problems when using bootstrap in conjunction with other javascript libraries.

If the original implementation was iffy to begin with, lets just remove it.

@cvrebert cvrebert added this to the v3.2.1 milestone May 29, 2014
@cvrebert cvrebert added the css label May 29, 2014
@mdo
Copy link
Member

mdo commented Jun 8, 2014

Fixed by #13707.

@mdo mdo closed this as completed Jun 8, 2014
@mdo mdo modified the milestones: v3.2.1, v3.2.0 Jun 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants