Skip to content

Commit f07d870

Browse files
author
Jon Wolski
committed
Remove color property from badge class
I suggest removing `color: #FFF` from the `badge` class, because it is provided by the `badge-<modifier>` classes along with a background-color, whereas there is no corresponding background-color provided on the `badge` class itself. Background ---------- According to the documentation: > [badge] Requires one of the contextual, color modifier classes for `color` and > `background-color`. That is, color and background color should be provided by a modifier class, rather than the badge class itself. e.g. `<span class='badge badge-primary'>4</span>` In general, providing a `color` property without also providing a `background-color` should be avoided. [W3 QA tips] In this context, this is a problem only if someone creates a `badge` without providing a modifier. Such an omition may be difficult to trouble-shoot, because this will most likely yield white text on a white background. [W3 QA tips](https://www.w3.org/QA/Tips/color)
1 parent 74d9639 commit f07d870

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

scss/_badge.scss

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
font-size: $badge-font-size;
1010
font-weight: $badge-font-weight;
1111
line-height: 1;
12-
color: $badge-color;
1312
text-align: center;
1413
white-space: nowrap;
1514
vertical-align: baseline;

0 commit comments

Comments
 (0)