Dropdown: fix variable always evaluating to true (#31673)

XhmikosR · web-flow · commit dc2f1e68cd32 · 2020-09-18T10:22:24.000+03:00
diff --git a/js/src/dropdown.js b/js/src/dropdown.js
@@ -469,7 +469,7 @@ class Dropdown {
     event.preventDefault()
     event.stopPropagation()
 
-    if (!isActive || isActive && (event.which === ESCAPE_KEYCODE || event.which === SPACE_KEYCODE)) {
+    if (!isActive || (event.which === ESCAPE_KEYCODE || event.which === SPACE_KEYCODE)) {
       if (event.which === ESCAPE_KEYCODE) {
         $(parent.querySelector(SELECTOR_DATA_TOGGLE)).trigger('focus')
       }

Original file line number	Diff line number	Diff line change
`@@ -469,7 +469,7 @@ class Dropdown {`
`469`	`469`	`event.preventDefault()`
`470`	`470`	`event.stopPropagation()`
`471`	`471`
`472`		`- if (!isActive \|\| isActive && (event.which === ESCAPE_KEYCODE \|\| event.which === SPACE_KEYCODE)) {`
	`472`	`+ if (!isActive \|\| (event.which === ESCAPE_KEYCODE \|\| event.which === SPACE_KEYCODE)) {`
`473`	`473`	`if (event.which === ESCAPE_KEYCODE) {`
`474`	`474`	`$(parent.querySelector(SELECTOR_DATA_TOGGLE)).trigger('focus')`
`475`	`475`	`}`