Skip to content

Commit bea6154

Browse files
Fix/add more correct labels/descriptions for input group examples (#26551)
Among other things, closes #26548
1 parent b36599c commit bea6154

File tree

1 file changed

+27
-27
lines changed

1 file changed

+27
-27
lines changed

docs/4.1/components/input-group.md

Lines changed: 27 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -63,21 +63,21 @@ Add the relative form sizing classes to the `.input-group` itself and contents w
6363
<div class="input-group-prepend">
6464
<span class="input-group-text" id="inputGroup-sizing-sm">Small</span>
6565
</div>
66-
<input type="text" class="form-control" aria-label="Small" aria-describedby="inputGroup-sizing-sm">
66+
<input type="text" class="form-control" aria-label="Sizing example input" aria-describedby="inputGroup-sizing-sm">
6767
</div>
6868

6969
<div class="input-group mb-3">
7070
<div class="input-group-prepend">
7171
<span class="input-group-text" id="inputGroup-sizing-default">Default</span>
7272
</div>
73-
<input type="text" class="form-control" aria-label="Default" aria-describedby="inputGroup-sizing-default">
73+
<input type="text" class="form-control" aria-label="Sizing example input" aria-describedby="inputGroup-sizing-default">
7474
</div>
7575

7676
<div class="input-group input-group-lg">
7777
<div class="input-group-prepend">
7878
<span class="input-group-text" id="inputGroup-sizing-lg">Large</span>
7979
</div>
80-
<input type="text" class="form-control" aria-label="Large" aria-describedby="inputGroup-sizing-sm">
80+
<input type="text" class="form-control" aria-label="Sizing example input" aria-describedby="inputGroup-sizing-lg">
8181
</div>
8282
{% endcapture %}
8383
{% include example.html content=example %}
@@ -99,7 +99,7 @@ Place any checkbox or radio option within an input group's addon instead of text
9999
<div class="input-group">
100100
<div class="input-group-prepend">
101101
<div class="input-group-text">
102-
<input type="radio" aria-label="Radio button for following text input">
102+
<input type="radio" aria-label="Radio button for following text input">
103103
</div>
104104
</div>
105105
<input type="text" class="form-control" aria-label="Text input with radio button">
@@ -114,10 +114,10 @@ While multiple `<input>`s are supported visually, validation styles are only ava
114114
{% capture example %}
115115
<div class="input-group">
116116
<div class="input-group-prepend">
117-
<span class="input-group-text" id="">First and last name</span>
117+
<span class="input-group-text">First and last name</span>
118118
</div>
119-
<input type="text" class="form-control">
120-
<input type="text" class="form-control">
119+
<input type="text" aria-label="First name" class="form-control">
120+
<input type="text" aria-label="Last name" class="form-control">
121121
</div>
122122
{% endcapture %}
123123
{% include example.html content=example %}
@@ -132,11 +132,11 @@ Multiple add-ons are supported and can be mixed with checkbox and radio input ve
132132
<span class="input-group-text">$</span>
133133
<span class="input-group-text">0.00</span>
134134
</div>
135-
<input type="text" class="form-control" aria-label="Amount (to the nearest dollar)">
135+
<input type="text" class="form-control" aria-label="Dollar amount (with dot and two decimal places)">
136136
</div>
137137

138138
<div class="input-group">
139-
<input type="text" class="form-control" aria-label="Amount (to the nearest dollar)">
139+
<input type="text" class="form-control" aria-label="Dollar amount (with dot and two decimal places)">
140140
<div class="input-group-append">
141141
<span class="input-group-text">$</span>
142142
<span class="input-group-text">0.00</span>
@@ -150,29 +150,29 @@ Multiple add-ons are supported and can be mixed with checkbox and radio input ve
150150
{% capture example %}
151151
<div class="input-group mb-3">
152152
<div class="input-group-prepend">
153-
<button class="btn btn-outline-secondary" type="button">Button</button>
153+
<button class="btn btn-outline-secondary" type="button" id="button-addon1">Button</button>
154154
</div>
155-
<input type="text" class="form-control" placeholder="" aria-label="" aria-describedby="basic-addon1">
155+
<input type="text" class="form-control" placeholder="" aria-label="Example text with button addon" aria-describedby="button-addon1">
156156
</div>
157157

158158
<div class="input-group mb-3">
159-
<input type="text" class="form-control" placeholder="Recipient's username" aria-label="Recipient's username" aria-describedby="basic-addon2">
159+
<input type="text" class="form-control" placeholder="Recipient's username" aria-label="Recipient's username" aria-describedby="button-addon2">
160160
<div class="input-group-append">
161-
<button class="btn btn-outline-secondary" type="button">Button</button>
161+
<button class="btn btn-outline-secondary" type="button" id="button-addon2">Button</button>
162162
</div>
163163
</div>
164164

165165
<div class="input-group mb-3">
166-
<div class="input-group-prepend">
166+
<div class="input-group-prepend" id="button-addon3">
167167
<button class="btn btn-outline-secondary" type="button">Button</button>
168168
<button class="btn btn-outline-secondary" type="button">Button</button>
169169
</div>
170-
<input type="text" class="form-control" placeholder="" aria-label="" aria-describedby="basic-addon1">
170+
<input type="text" class="form-control" placeholder="" aria-label="Example text with two button addons" aria-describedby="button-addon3">
171171
</div>
172172

173173
<div class="input-group">
174-
<input type="text" class="form-control" placeholder="Recipient's username" aria-label="Recipient's username" aria-describedby="basic-addon2">
175-
<div class="input-group-append">
174+
<input type="text" class="form-control" placeholder="Recipient's username" aria-label="Recipient's username with two button addons" aria-describedby="button-addon4">
175+
<div class="input-group-append" id="button-addon4">
176176
<button class="btn btn-outline-secondary" type="button">Button</button>
177177
<button class="btn btn-outline-secondary" type="button">Button</button>
178178
</div>
@@ -287,7 +287,7 @@ Input groups include support for custom selects and custom file inputs. Browser
287287
<div class="input-group-prepend">
288288
<button class="btn btn-outline-secondary" type="button">Button</button>
289289
</div>
290-
<select class="custom-select" id="inputGroupSelect03">
290+
<select class="custom-select" id="inputGroupSelect03" aria-label="Example select with button addon">
291291
<option selected>Choose...</option>
292292
<option value="1">One</option>
293293
<option value="2">Two</option>
@@ -296,7 +296,7 @@ Input groups include support for custom selects and custom file inputs. Browser
296296
</div>
297297

298298
<div class="input-group">
299-
<select class="custom-select" id="inputGroupSelect04">
299+
<select class="custom-select" id="inputGroupSelect04" aria-label="Example select with button addon">
300300
<option selected>Choose...</option>
301301
<option value="1">One</option>
302302
<option value="2">Two</option>
@@ -314,41 +314,41 @@ Input groups include support for custom selects and custom file inputs. Browser
314314
{% capture example %}
315315
<div class="input-group mb-3">
316316
<div class="input-group-prepend">
317-
<span class="input-group-text">Upload</span>
317+
<span class="input-group-text" id="inputGroupFileAddon01">Upload</span>
318318
</div>
319319
<div class="custom-file">
320-
<input type="file" class="custom-file-input" id="inputGroupFile01">
320+
<input type="file" class="custom-file-input" id="inputGroupFile01" aria-describedby="inputGroupFileAddon01">
321321
<label class="custom-file-label" for="inputGroupFile01">Choose file</label>
322322
</div>
323323
</div>
324324

325325
<div class="input-group mb-3">
326326
<div class="custom-file">
327327
<input type="file" class="custom-file-input" id="inputGroupFile02">
328-
<label class="custom-file-label" for="inputGroupFile02">Choose file</label>
328+
<label class="custom-file-label" for="inputGroupFile02" aria-describedby="inputGroupFileAddon02">Choose file</label>
329329
</div>
330330
<div class="input-group-append">
331-
<span class="input-group-text" id="">Upload</span>
331+
<span class="input-group-text" id="inputGroupFileAddon02">Upload</span>
332332
</div>
333333
</div>
334334

335335
<div class="input-group mb-3">
336336
<div class="input-group-prepend">
337-
<button class="btn btn-outline-secondary" type="button">Button</button>
337+
<button class="btn btn-outline-secondary" type="button" id="inputGroupFileAddon03">Button</button>
338338
</div>
339339
<div class="custom-file">
340-
<input type="file" class="custom-file-input" id="inputGroupFile03">
340+
<input type="file" class="custom-file-input" id="inputGroupFile03" aria-describedby="inputGroupFileAddon03">
341341
<label class="custom-file-label" for="inputGroupFile03">Choose file</label>
342342
</div>
343343
</div>
344344

345345
<div class="input-group">
346346
<div class="custom-file">
347-
<input type="file" class="custom-file-input" id="inputGroupFile04">
347+
<input type="file" class="custom-file-input" id="inputGroupFile04" aria-describedby="inputGroupFileAddon04">
348348
<label class="custom-file-label" for="inputGroupFile04">Choose file</label>
349349
</div>
350350
<div class="input-group-append">
351-
<button class="btn btn-outline-secondary" type="button">Button</button>
351+
<button class="btn btn-outline-secondary" type="button" id="inputGroupFileAddon04">Button</button>
352352
</div>
353353
</div>
354354
{% endcapture %}

0 commit comments

Comments
 (0)