Match the height of select.form-control with input.form-control

mdo · mdo · commit 0c467e7b29e2 · 2016-10-09T18:04:30.000-07:00
Uses a local variable and some calc love to counteract the border-width (times 2) from the height of the select. Fixes #17194 and nullifies #19967.
diff --git a/scss/_forms.scss b/scss/_forms.scss
@@ -66,7 +66,8 @@
 
 select.form-control {
   &:not([size]):not([multiple]) {
-    height: $input-height;
+    $select-border-width: ($border-width * 2);
+    height: calc(#{$input-height} - #{$select-border-width});
   }
 
   &:focus::-ms-value {

Original file line number	Diff line number	Diff line change
`@@ -66,7 +66,8 @@`
`66`	`66`
`67`	`67`	`select.form-control {`
`68`	`68`	`&:not([size]):not([multiple]) {`
`69`		`- height: $input-height;`
	`69`	`+ $select-border-width: ($border-width * 2);`
	`70`	`+ height: calc(#{$input-height} - #{$select-border-width});`
`70`	`71`	`}`
`71`	`72`
`72`	`73`	`&:focus::-ms-value {`