Skip to content

Commit 05d88ca

Browse files
patrickhlaukemdo
authored andcommitted
Fix docs horizontal scrollbar (#24878)
* Fix docs horizontal scrollbar in Components > Modal * Add overflow to docs example class * Drop the handleUpdate() variant While I understand the variant covers the "get a particular plugin instance" case from http://getbootstrap.com/docs/4.0/getting-started/javascript/#programmatic-api it seems weird that we do it here but not everywhere else in the docs (randomly checking other pages, we seem to stick to the documented methods as written on those pages). As this isn't properly explained as is, and as it adds nothing (more of a preference for authors), it would be easier to just drop the variant and stick with the documented method as outlined later on in the same page (avoids having to go off on a "why should you use this instead of that" tangent here).
1 parent 7629567 commit 05d88ca

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

assets/scss/_component-examples.scss

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -118,6 +118,7 @@
118118
position: relative;
119119
padding: 1rem;
120120
margin: 1rem (-$grid-gutter-width / 2);
121+
overflow: auto;
121122
border: solid #f7f7f9;
122123
border-width: .2rem 0 0;
123124
@include clearfix();

docs/4.0/components/modal.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -459,7 +459,7 @@ For modals that simply appear rather than fade in to view, remove the `.fade` cl
459459

460460
### Dynamic heights
461461

462-
If the height of a modal changes while it is open, you should call `$('#myModal').data('bs.modal').handleUpdate()` or `$('#myModal').modal('handleUpdate')` to readjust the modal's position in case a scrollbar appears.
462+
If the height of a modal changes while it is open, you should call `$('#myModal').modal('handleUpdate')` to readjust the modal's position in case a scrollbar appears.
463463

464464
### Accessibility
465465

0 commit comments

Comments
 (0)