Skip to content

Commit 0581234

Browse files
andresgalantemdo
authored andcommitted
Convert px values to rem on tooltip variables (#23468)
* converts px valures to rem on tooltip variables * keep as px to match popover changes
1 parent b931070 commit 0581234

File tree

2 files changed

+15
-16
lines changed

2 files changed

+15
-16
lines changed

scss/_tooltip.scss

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
}
3535

3636
.arrow::before {
37-
margin-left: -($tooltip-arrow-width - 2);
37+
margin-left: -$tooltip-arrow-width;
3838
content: "";
3939
border-width: $tooltip-arrow-width $tooltip-arrow-width 0;
4040
border-top-color: $tooltip-arrow-color;
@@ -47,7 +47,7 @@
4747
}
4848

4949
.arrow::before {
50-
margin-top: -($tooltip-arrow-width - 2);
50+
margin-top: -$tooltip-arrow-width;
5151
content: "";
5252
border-width: $tooltip-arrow-width $tooltip-arrow-width $tooltip-arrow-width 0;
5353
border-right-color: $tooltip-arrow-color;
@@ -60,7 +60,7 @@
6060
}
6161

6262
.arrow::before {
63-
margin-left: -($tooltip-arrow-width - 2);
63+
margin-left: -$tooltip-arrow-width;
6464
content: "";
6565
border-width: 0 $tooltip-arrow-width $tooltip-arrow-width;
6666
border-bottom-color: $tooltip-arrow-color;
@@ -74,7 +74,7 @@
7474

7575
.arrow::before {
7676
right: 0;
77-
margin-top: -($tooltip-arrow-width - 2);
77+
margin-top: -($tooltip-arrow-width);
7878
content: "";
7979
border-width: $tooltip-arrow-width 0 $tooltip-arrow-width $tooltip-arrow-width;
8080
border-left-color: $tooltip-arrow-color;

scss/_variables.scss

Lines changed: 11 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -665,18 +665,17 @@ $card-columns-margin: $card-spacer-y !default;
665665

666666
// Tooltips
667667

668-
$tooltip-max-width: 200px !default;
669-
$tooltip-color: $white !default;
670-
$tooltip-bg: $black !default;
671-
$tooltip-opacity: .9 !default;
672-
$tooltip-padding-y: 3px !default;
673-
$tooltip-padding-x: 8px !default;
674-
$tooltip-margin: 0 !default;
675-
676-
677-
$tooltip-arrow-width: 5px !default;
678-
$tooltip-arrow-height: 5px !default;
679-
$tooltip-arrow-color: $tooltip-bg !default;
668+
$tooltip-max-width: 200px !default;
669+
$tooltip-color: $white !default;
670+
$tooltip-bg: $black !default;
671+
$tooltip-opacity: .9 !default;
672+
$tooltip-padding-y: .25rem !default;
673+
$tooltip-padding-x: .5rem !default;
674+
$tooltip-margin: 0 !default;
675+
676+
$tooltip-arrow-width: .4rem !default;
677+
$tooltip-arrow-height: $tooltip-arrow-width !default;
678+
$tooltip-arrow-color: $tooltip-bg !default;
680679

681680

682681
// Popovers

0 commit comments

Comments
 (0)