Skip to content

.col-xs-12 now required on every responsive col? #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sbleon opened this issue Jul 28, 2016 · 2 comments
Closed

.col-xs-12 now required on every responsive col? #48

sbleon opened this issue Jul 28, 2016 · 2 comments

Comments

@sbleon
Copy link

sbleon commented Jul 28, 2016

Thanks for all of your work on v4! I'm enjoying working with it thus far! 😄

Sometime since the release of Alpha 3, the grid appears to have changed and now every responsive col seems to need to have .col-xs-12 in order to size correctly in XS viewports.

Correct width without col-xs-12 in alpha3:

<div class="row" style="background-color: yellow">
  <div class="col-md-6 offset-md-3" style="background-color: blue">
    <div class="card">
      <div class="card-block">
        Correct width without col-xs-12
        <br>
        dc6648900ffe8609188a7bf904bd765a492471b9
        <br>
        4.0.0.alpha3
      </div>
    </div>
  </div>
</div>

screen shot 2016-07-28 at 1 39 45 pm

Incorrect width without col-xs-12 in f6a7b7b:

<div class="row" style="background-color: yellow">
  <div class="col-md-6 offset-md-3" style="background-color: blue">
    <div class="card">
      <div class="card-block">
        Incorrect width without col-xs-12
        <br>
        f6a7b7bf41ea628b61693597be299c4257f93079
      </div>
    </div>
  </div>
</div>

screen shot 2016-07-28 at 1 38 17 pm

To correct width in f6a7b7b, we must add .col-xs-12 to every responsive col in our application:

<div class="row" style="background-color: yellow">
  <div class="col-xs-12 col-md-6 offset-md-3" style="background-color: blue">
    <div class="card">
      <div class="card-block">
        Correct width with col-xs-12
        <br>
        f6a7b7bf41ea628b61693597be299c4257f93079
      </div>
    </div>
  </div>
</div>

screen shot 2016-07-28 at 1 37 55 pm

I wanted to make sure that this change was intentional and see if anyone can explain the reasoning behind it. I think it makes for a poorer developer experience, both because of the extra typing and because of the change in behavior from what we're used to in v3. It also seems to be at odds with a mobile-first philosophy, where you don't have to do anything for XS because it is assumed to be the default.

@glebm
Copy link
Member

glebm commented Jul 31, 2016

The alpha3 release of this gem is actually much older than the upstream release. There is now a new version out that corresponds to the upstream Alpha 3: https://rubygems.org/gems/bootstrap/versions/4.0.0.alpha3.1.

I don't know if this behaviour is different in the new version, but if it isn't then this issue should be raised in the upstream tracker as this repository just handles the rubygem-specific code.

@glebm glebm closed this as completed Jul 31, 2016
@sbleon
Copy link
Author

sbleon commented Aug 1, 2016

Thanks, Gleb, for pointing out the upstream project, and for clarifying the odd release date incongruence between the two. I was pretty confused by that last week!

For the record, the behavior I described was a bug :-) , but had already been fixed upstream when I reported it here. Doh!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants