Skip to content

Duplicate #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
michaelavila opened this issue Aug 16, 2014 · 6 comments
Closed

Duplicate #3

michaelavila opened this issue Aug 16, 2014 · 6 comments

Comments

@michaelavila
Copy link

Hi there,

I needed to use this client and had to make a few changes to get it to work. I also put it on Cocoapods. I changed the layout of the project to be more standard.

Anyway, I thought it worth offering to just transfer it to you guys if you'd like it. It's here: michaelavila/TUSKit, Let me know. As it stands the client you have in your repo does not work with any TUS servers. It has to do with a change in the headers, Final-Length should be Entity-Length. I've made that change already in my repo. And have verified that it works.

Let me know if you all want it. Take care.

@kvz
Copy link
Member

kvz commented Aug 17, 2014

Hi, thanks a lot for contributing. This looks like a good improvement over our current iOS client. How would you feel taking ownership of this project and releasing your version as the next major version (1.0.0)? I would request you specify in the readme which tus version you target (v0.2.2) though. A next idea of improvement would be utilizing Travis to get some tests running, but that can be done later on.

Let me know if you're interested and I'll make it happen.

@michaelavila
Copy link
Author

@kvz that sounds great. I'd like to help out. I will make the updates you mentioned. Thanks for responding so quickly.

@kvz
Copy link
Member

kvz commented Aug 18, 2014

Alright I added you as a collaborator, please tag the current state as 0.0.1 and make your version the 1.0. Thanks for helping out!

@michaelavila
Copy link
Author

@kvz Sounds great, I'll take care of this today. Thanks and cheers!

@michaelavila
Copy link
Author

@kvz are you sure it was my username you added as a collaborator? It appears to either have not worked, or potentially someone else was added? I have some time today to get these changes made and get this repo sorted out. Thanks again.

@michaelavila
Copy link
Author

@kvz nvm, all is resolved. Disregard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants