Skip to content

Commit 8c66fcc

Browse files
committed
Do not retrieve hidden zpool properties
zprop_iter provides an interface to iterate over all available zpool properties. To iterate over hidden zpool properties, show_all parameter should be set to true. Recently, dedupcached property was added as part of fast dedup support in ZFS. This property is quite expensive since it needs to calculate the total size of dedup table loaded into the ARC. This commit updates the show_all parameter passed to zprop_iter, and sets it to False, since we don't want to retrieve the dedupcached property. All other hidden zpool properties will not be retrieved either as part of zprop_iter. These properties include name, tname, maxblocksize, maxdnodesize, dedupditto and dedupcached. Signed-off-by: Umer Saleem <[email protected]>
1 parent 184a004 commit 8c66fcc

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

libzfs.pyx

+1-1
Original file line numberDiff line numberDiff line change
@@ -3127,7 +3127,7 @@ cdef class ZFSPool(object):
31273127
result = {}
31283128

31293129
with nogil:
3130-
libzfs.zprop_iter(self.__iterate_props, <void*>proptypes, True, True, zfs.ZFS_TYPE_POOL)
3130+
libzfs.zprop_iter(self.__iterate_props, <void*>proptypes, False, True, zfs.ZFS_TYPE_POOL)
31313131

31323132
for x in proptypes:
31333133
prop = ZPoolProperty.__new__(ZPoolProperty)

0 commit comments

Comments
 (0)