[BUILD] Bump cmake requirement to >= 3.20 and format CMakeLists.txt (#1276)

cc @malfet

Author: Jokeren

CMakeLists.txt

@@ -1,5 +1,7 @@
-cmake_minimum_required(VERSION 3.6)
+cmake_minimum_required(VERSION 3.20)
 
+# Introduced in cmake 3.20
+# https://cmake.org/cmake/help/latest/policy/CMP0116.html
 cmake_policy(SET CMP0116 OLD)
 
 include(ExternalProject)
@@ -10,6 +12,7 @@ set(CMAKE_INCLUDE_CURRENT_DIR ON)
 
 project(triton)
 include(CTest)
+
 if(NOT WIN32)
   list(APPEND CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/cmake")
 endif()
@@ -19,7 +22,7 @@ option(TRITON_BUILD_TUTORIALS "Build C++ Triton tutorials" ON)
 option(TRITON_BUILD_PYTHON_MODULE "Build Python Triton bindings" OFF)
 
 # Ensure Python3 vars are set correctly
-#  used conditionally in this file and by lit tests
+# used conditionally in this file and by lit tests
 
 # Customized release build type with assertions: TritonRelBuildWithAsserts
 set(CMAKE_C_FLAGS_TRITONRELBUILDWITHASSERTS "-O2 -g")
@@ -32,7 +35,7 @@ if(NOT CMAKE_BUILD_TYPE)
 endif()
 
 if(NOT WIN32)
-    find_library(TERMINFO_LIBRARY tinfo)
+  find_library(TERMINFO_LIBRARY tinfo)
 endif()
 
 # Compiler flags
@@ -42,22 +45,21 @@ include_directories(${CMAKE_CURRENT_SOURCE_DIR}/include)
 include_directories(${PYBIND11_INCLUDE_DIR})
 
 if(WIN32)
-    SET(BUILD_SHARED_LIBS OFF)
-    find_package(dlfcn-win32 REQUIRED)
-    set(CMAKE_DL_LIBS dlfcn-win32::dl)
+  SET(BUILD_SHARED_LIBS OFF)
+  find_package(dlfcn-win32 REQUIRED)
+  set(CMAKE_DL_LIBS dlfcn-win32::dl)
 endif()
 
 set(CMAKE_CXX_FLAGS "${CMAKE_C_FLAGS} -D__STDC_FORMAT_MACROS  -fPIC -std=gnu++17 -fvisibility=hidden -fvisibility-inlines-hidden")
+
 if(APPLE)
   set(CMAKE_OSX_DEPLOYMENT_TARGET 11.6)
 endif()
 
-
-
-##########
+# #########
 # LLVM
-##########
-if (NOT MLIR_DIR)
+# #########
+if(NOT MLIR_DIR)
   if(NOT LLVM_LIBRARY_DIR)
     if(WIN32)
       find_package(LLVM 13 REQUIRED COMPONENTS nvptx amdgpu)
@@ -73,12 +75,16 @@ if (NOT MLIR_DIR)
     else()
       find_package(LLVM 11 REQUIRED COMPONENTS "nvptx;amdgpu")
     endif()
+
     message(STATUS "Found LLVM ${LLVM_PACKAGE_VERSION}")
+
     # FindLLVM outputs LLVM_LIBRARY_DIRS but we expect LLVM_LIBRARY_DIR here
     set(LLVM_LIBRARY_DIR ${LLVM_LIBRARY_DIRS})
+
     if(APPLE)
       set(CMAKE_OSX_DEPLOYMENT_TARGET "10.14")
     endif()
+
   # sometimes we don't want to use llvm-config, since it may have been downloaded for some specific linux distros
   else()
     set(LLVM_LDFLAGS "-L${LLVM_LIBRARY_DIR}")
@@ -138,37 +144,38 @@ if (NOT MLIR_DIR)
       libLLVMAnalysis.a
     )
   endif()
-  set (MLIR_DIR ${LLVM_LIBRARY_DIR}/cmake/mlir)
+
+  set(MLIR_DIR ${LLVM_LIBRARY_DIR}/cmake/mlir)
 endif()
 
 # Python module
 if(TRITON_BUILD_PYTHON_MODULE)
-    message(STATUS "Adding Python module")
-    set(PYTHON_SRC_PATH ${CMAKE_CURRENT_SOURCE_DIR}/python/src)
-    set(PYTHON_SRC ${PYTHON_SRC_PATH}/main.cc ${PYTHON_SRC_PATH}/triton.cc)
-    include_directories("." ${PYTHON_SRC_PATH})
-    if (PYTHON_INCLUDE_DIRS)
-      include_directories(${PYTHON_INCLUDE_DIRS})
-    else()
-      find_package(Python3 REQUIRED COMPONENTS Development Interpreter)
-      include_directories(${Python3_INCLUDE_DIRS})
-      link_directories(${Python3_LIBRARY_DIRS})
-      link_libraries(${Python3_LIBRARIES})
-      add_link_options(${Python3_LINK_OPTIONS})
-    endif()
+  message(STATUS "Adding Python module")
+  set(PYTHON_SRC_PATH ${CMAKE_CURRENT_SOURCE_DIR}/python/src)
+  set(PYTHON_SRC ${PYTHON_SRC_PATH}/main.cc ${PYTHON_SRC_PATH}/triton.cc)
+  include_directories("." ${PYTHON_SRC_PATH})
+
+  if(PYTHON_INCLUDE_DIRS)
+    include_directories(${PYTHON_INCLUDE_DIRS})
+  else()
+    find_package(Python3 REQUIRED COMPONENTS Development Interpreter)
+    include_directories(${Python3_INCLUDE_DIRS})
+    link_directories(${Python3_LIBRARY_DIRS})
+    link_libraries(${Python3_LIBRARIES})
+    add_link_options(${Python3_LINK_OPTIONS})
+  endif()
 endif()
 
 # # Triton
 # file(GLOB_RECURSE LIBTRITON_SRC lib/*.cc)
 # if (WIN32 AND TRITON_BUILD_PYTHON_MODULE)
-#     Python3_add_library(triton SHARED ${LIBTRITON_SRC} ${PYTHON_SRC})
-#     set_target_properties(triton PROPERTIES SUFFIX ".pyd")
-#     set_target_properties(triton PROPERTIES PREFIX "lib")
+# Python3_add_library(triton SHARED ${LIBTRITON_SRC} ${PYTHON_SRC})
+# set_target_properties(triton PROPERTIES SUFFIX ".pyd")
+# set_target_properties(triton PROPERTIES PREFIX "lib")
 # else()
-#     add_library(triton SHARED ${LIBTRITON_SRC} ${PYTHON_SRC})
+# add_library(triton SHARED ${LIBTRITON_SRC} ${PYTHON_SRC})
 # endif()
 
-
 # MLIR
 find_package(MLIR REQUIRED CONFIG PATHS ${MLIR_DIR})
 
@@ -186,14 +193,13 @@ include_directories(${MLIR_INCLUDE_DIRS})
 include_directories(${LLVM_INCLUDE_DIRS})
 include_directories(${PROJECT_SOURCE_DIR}/include)
 include_directories(${PROJECT_BINARY_DIR}/include) # Tablegen'd files
-# link_directories(${LLVM_LIBRARY_DIR})
 
+# link_directories(${LLVM_LIBRARY_DIR})
 add_subdirectory(include)
 add_subdirectory(lib)
 add_subdirectory(bin)
 
 # find_package(PythonLibs REQUIRED)
-
 set(TRITON_SOURCE_DIR "${CMAKE_CURRENT_SOURCE_DIR}")
 set(TRITON_BINARY_DIR "${CMAKE_CURRENT_BINARY_DIR}")
 
@@ -210,6 +216,7 @@ if(TRITON_BUILD_PYTHON_MODULE)
     TritonPTX
     ${dialect_libs}
     ${conversion_libs}
+
     # optimizations
     MLIRPass
     MLIRTransforms
@@ -221,6 +228,7 @@ if(TRITON_BUILD_PYTHON_MODULE)
     MLIRNVVMToLLVMIRTranslation
     MLIRIR
   )
+
   if(WIN32)
     target_link_libraries(triton PRIVATE ${LLVM_LIBRARIES} ${CMAKE_DL_LIBS}
       ${TRITON_LIBRARIES}
@@ -234,21 +242,23 @@ if(TRITON_BUILD_PYTHON_MODULE)
       ${TRITON_LIBRARIES}
     )
   endif()
-  
+
   target_link_options(triton PRIVATE ${LLVM_LDFLAGS})
 endif()
 
-if (UNIX AND NOT APPLE)
+if(UNIX AND NOT APPLE)
   set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} -Wl,--exclude-libs,ALL")
 endif()
 
 if(TRITON_BUILD_PYTHON_MODULE AND NOT WIN32)
-    set(CMAKE_SHARED_LIBRARY_SUFFIX ".so")
-    # Check if the platform is MacOS
-    if(APPLE)
-        set(PYTHON_LDFLAGS "-undefined dynamic_lookup -flto")
-    endif()
-    target_link_libraries(triton ${CUTLASS_LIBRARIES} ${PYTHON_LDFLAGS})
+  set(CMAKE_SHARED_LIBRARY_SUFFIX ".so")
+
+  # Check if the platform is MacOS
+  if(APPLE)
+    set(PYTHON_LDFLAGS "-undefined dynamic_lookup -flto")
+  endif()
+
+  target_link_libraries(triton ${CUTLASS_LIBRARIES} ${PYTHON_LDFLAGS})
 endif()
 
 add_subdirectory(test)

python/setup.py

@@ -215,7 +215,7 @@ def build_extension(self, ext):
     long_description="",
     packages=["triton", "triton/_C", "triton/language", "triton/tools", "triton/impl", "triton/ops", "triton/runtime", "triton/ops/blocksparse"],
     install_requires=[
-        "cmake",
+        "cmake>=3.20",
         "filelock",
         "torch",
         "lit",