Skip to content

Commit f2894c1

Browse files
authored
switch to busybox and only call post start hook for restore (#1005)
1 parent e35f297 commit f2894c1

File tree

3 files changed

+19
-8
lines changed

3 files changed

+19
-8
lines changed

.changeset/polite-ducks-switch.md

+5
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"trigger.dev": patch
3+
---
4+
5+
Fix post start hooks

apps/kubernetes-provider/src/index.ts

+10-7
Original file line numberDiff line numberDiff line change
@@ -152,11 +152,6 @@ class KubernetesTaskOperations implements TaskOperations {
152152
},
153153
},
154154
lifecycle: {
155-
postStart: {
156-
exec: {
157-
command: this.#getLifecycleCommand("postStart", "create"),
158-
},
159-
},
160155
preStop: {
161156
exec: {
162157
command: this.#getLifecycleCommand("preStop", "terminate"),
@@ -404,11 +399,19 @@ class KubernetesTaskOperations implements TaskOperations {
404399
type: THookType,
405400
cause: THookType extends "postStart" ? PostStartCauses : PreStopCauses
406401
) {
407-
const retries = 5
402+
const retries = 5;
408403

409404
// This will retry sending the lifecycle hook up to `retries` times
410405
// The sleep is required as this may start running before the HTTP server is up
411-
return ["/bin/sh", "-c", `for i in $(seq ${retries}); do sleep 1; wget -q -O- 127.0.0.1:8000/${type}?cause=${cause} && break; done`];
406+
const exec = [
407+
"/bin/sh",
408+
"-c",
409+
`for i in $(seq ${retries}); do sleep 1; busybox wget -q -O- 127.0.0.1:8000/${type}?cause=${cause} && break; done`,
410+
];
411+
412+
logger.log("getLifecycleCommand()", { exec });
413+
414+
return exec;
412415
}
413416

414417
#getIndexContainerName(suffix: string) {

packages/cli-v3/src/Containerfile.prod

+4-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,10 @@
11
FROM node:20-bookworm-slim@sha256:d4cdfc305abe5ea78da7167bf78263c22596dc332f2654b662890777ea166224 AS base
22

33
ENV DEBIAN_FRONTEND=noninteractive
4-
RUN apt-get update && apt-get install -y --no-install-recommends dumb-init && rm -rf /var/lib/apt/lists/*
4+
RUN apt-get update && apt-get install -y --no-install-recommends \
5+
busybox \
6+
dumb-init \
7+
&& rm -rf /var/lib/apt/lists/*
58

69
# Create and set workdir with appropriate permissions
710
RUN mkdir /app && chown node:node /app

0 commit comments

Comments
 (0)