Remove setters from fly::net::Endpoint

The awkward use case that required these has been removed.

Author: trflynn89

fly/net/endpoint.hpp

@@ -77,32 +77,11 @@ class Endpoint
      */
     static constexpr std::optional<Endpoint> from_string(std::string_view endpoint);
 
-    /**
-     * Set the endpoint's IP address.
-     *
-     * @param address The endoint's new IP address.
-     */
-    void set_address(const IPAddressType &address);
-
-    /**
-     * Set the endpoint's IP address.
-     *
-     * @param address The endoint's new IP address.
-     */
-    void set_address(IPAddressType &&address);
-
     /**
      * @return The endoint's IP address.
      */
     constexpr const IPAddressType &address() const;
 
-    /**
-     * Set the endpoint's port.
-     *
-     * @param port The endoint's new port.
-     */
-    void set_port(port_type port);
-
     /**
      * @return The endoint's IP port.
      */
@@ -211,20 +190,6 @@ Endpoint<IPAddressType>::from_string(std::string_view endpoint)
     return Endpoint(*std::move(address), static_cast<port_type>(*port));
 }
 
-//==================================================================================================
-template <typename IPAddressType>
-void Endpoint<IPAddressType>::set_address(const IPAddressType &address)
-{
-    m_address = address;
-}
-
-//==================================================================================================
-template <typename IPAddressType>
-void Endpoint<IPAddressType>::set_address(IPAddressType &&address)
-{
-    m_address = std::move(address);
-}
-
 //==================================================================================================
 template <typename IPAddressType>
 constexpr const IPAddressType &Endpoint<IPAddressType>::address() const
@@ -239,13 +204,6 @@ constexpr port_type Endpoint<IPAddressType>::port() const
     return m_port;
 }
 
-//==================================================================================================
-template <typename IPAddressType>
-void Endpoint<IPAddressType>::set_port(port_type port)
-{
-    m_port = port;
-}
-
 #if !defined(FLY_LINUX)
 
 //==================================================================================================

test/net/endpoint.cpp

@@ -88,31 +88,6 @@ CATCH_TEMPLATE_TEST_CASE("Endpoint", "[net]", fly::net::IPv4Address, fly::net::I
         static_assert(endpoint2 < endpoint3);
     }
 
-    CATCH_SECTION("Endpoints may be updated")
-    {
-        auto endpoint = EndpointType(IPAddressType::in_addr_any(), 1);
-
-        CATCH_CHECK(endpoint.address() == IPAddressType::in_addr_any());
-        CATCH_CHECK(endpoint.port() == 1);
-
-        const auto address1 = IPAddressType::in_addr_loopback();
-        endpoint.set_address(address1);
-
-        CATCH_CHECK(endpoint.address() == address1);
-        CATCH_CHECK(endpoint.port() == 1);
-
-        auto address2 = IPAddressType::in_addr_loopback();
-        endpoint.set_address(std::move(address2));
-
-        CATCH_CHECK(endpoint.address() == address1);
-        CATCH_CHECK(endpoint.port() == 1);
-
-        endpoint.set_port(2);
-
-        CATCH_CHECK(endpoint.address() == address1);
-        CATCH_CHECK(endpoint.port() == 2);
-    }
-
     if constexpr (EndpointType::is_ipv4())
     {
         CATCH_SECTION("Endpoints may be converted to a string")