Use safe BasicString::is_digit in JsonParser

trflynn89 · trflynn89 · commit 55e77cbee329 · 2021-01-03T12:13:51.000-05:00
diff --git a/fly/parser/json_parser.cpp b/fly/parser/json_parser.cpp
@@ -430,9 +430,9 @@ JsonParser::NumberType JsonParser::validate_number(const JsonTraits::string_type
     }
 
     const bool is_octal = (signless.size() > 1) && (signless[0] == '0') &&
-        std::isdigit(static_cast<unsigned char>(signless[1]));
+        JsonTraits::StringType::is_digit(signless[1]);
 
-    if (!std::isdigit(static_cast<unsigned char>(signless[0])) || is_octal)
+    if (!JsonTraits::StringType::is_digit(signless[0]) || is_octal)
     {
         return NumberType::Invalid;
     }

Original file line number	Diff line number	Diff line change
`@@ -430,9 +430,9 @@ JsonParser::NumberType JsonParser::validate_number(const JsonTraits::string_type`
`430`	`430`	`}`
`431`	`431`
`432`	`432`	`const bool is_octal = (signless.size() > 1) && (signless[0] == '0') &&`
`433`		`- std::isdigit(static_cast<unsigned char>(signless[1]));`
	`433`	`+ JsonTraits::StringType::is_digit(signless[1]);`
`434`	`434`
`435`		`- if (!std::isdigit(static_cast<unsigned char>(signless[0])) \|\| is_octal)`
	`435`	`+ if (!JsonTraits::StringType::is_digit(signless[0]) \|\| is_octal)`
`436`	`436`	`{`
`437`	`437`	`return NumberType::Invalid;`
`438`	`438`	`}`