Declare formatting options in derived formatters as public

This will allow the base BasicFormatSpecifier class to refer to these
members in derived classes without needing e.g. friendship.

Author: trflynn89

fly/types/string/detail/format_specifier.hpp

@@ -437,8 +437,6 @@ struct BasicFormatSpecifier
  * BasicFormatSpecifier.
  */
 #define FLY_DEFINE_FORMATTER(CharType, parameter_type)                                             \
-                                                                                                   \
-protected:                                                                                         \
     using FormatSpecifier = fly::detail::BasicFormatSpecifier<CharType>;                           \
     using FormatSpecifier::m_position;                                                             \
     using FormatSpecifier::m_fill;                                                                 \
@@ -455,7 +453,6 @@ protected:
     using FormatSpecifier::m_case;                                                                 \
     using FormatSpecifier::m_parameter_type;                                                       \
                                                                                                    \
-public:                                                                                            \
     Formatter()                                                                                    \
     {                                                                                              \
         m_parameter_type = parameter_type;                                                         \