Remove unused iterator-based Unicode converters

Author: trflynn89

fly/types/string/detail/string_unicode.hpp

@@ -60,22 +60,6 @@ class BasicStringUnicode
     template <typename DesiredStringType, typename SourceStringType = StringType>
     static std::optional<DesiredStringType> convert_encoding(SourceStringType &&value);
 
-    /**
-     * Convert the Unicode encoding of a string to another encoding.
-     *
-     * @tparam DesiredStringType The type of string to convert to.
-     * @tparam IteratorType The type of the encoded Unicode string's iterator.
-     *
-     * @param it Pointer to the beginning of the encoded Unicode string.
-     * @param end Pointer to the end of the encoded Unicode string.
-     *
-     * @return If successful, a copy of the source string with the desired encoding. Otherwise, an
-     *         uninitialized value.
-     */
-    template <typename DesiredStringType, typename IteratorType>
-    static std::optional<DesiredStringType>
-    convert_encoding(IteratorType &it, const IteratorType &end);
-
     /**
      * Convert the Unicode encoding of a string to another encoding, inserting the result into the
      * provided output iterator.
@@ -96,23 +80,6 @@ class BasicStringUnicode
         typename SourceStringType = StringType>
     static bool convert_encoding_into(SourceStringType &&value, OutputIteratorType out);
 
-    /**
-     * Convert the Unicode encoding of a string to another encoding, inserting the result into the
-     * provided output iterator.
-     *
-     * @tparam DesiredStringType The type of string to convert to.
-     * @tparam OutputIteratorType The type of the output iterator to insert the result into.
-     * @tparam SourceStringType The type of string to convert.
-     *
-     * @param value The encoded Unicode string to convert.
-     * @param out The output iterator to insert the result into.
-     *
-     * @return Whether the conversion was successful.
-     */
-    template <typename DesiredStringType, typename IteratorType, typename OutputIteratorType>
-    static bool
-    convert_encoding_into(IteratorType &it, const IteratorType &end, OutputIteratorType out);
-
     /**
      * Decode a single Unicode codepoint, starting at the character pointed to by the provided
      * iterator. If successful, after invoking this method, that iterator will point at the first
@@ -427,21 +394,13 @@ template <typename StringType>
 template <typename DesiredStringType, typename SourceStringType>
 inline std::optional<DesiredStringType>
 BasicStringUnicode<StringType>::convert_encoding(SourceStringType &&value)
-{
-    auto it = value.cbegin();
-    return convert_encoding<DesiredStringType>(it, value.cend());
-}
-
-//==================================================================================================
-template <typename StringType>
-template <typename DesiredStringType, typename IteratorType>
-std::optional<DesiredStringType>
-BasicStringUnicode<StringType>::convert_encoding(IteratorType &it, const IteratorType &end)
 {
     DesiredStringType result;
-    result.reserve(static_cast<typename StringType::size_type>(std::distance(it, end)));
+    result.reserve(static_cast<typename StringType::size_type>(value.size()));
 
-    if (convert_encoding_into<DesiredStringType>(it, end, std::back_inserter(result)))
+    if (convert_encoding_into<DesiredStringType>(
+            std::forward<SourceStringType>(value),
+            std::back_inserter(result)))
     {
         return result;
     }
@@ -455,21 +414,12 @@ template <typename DesiredStringType, typename OutputIteratorType, typename Sour
 bool BasicStringUnicode<StringType>::convert_encoding_into(
     SourceStringType &&value,
     OutputIteratorType out)
-{
-    auto it = value.cbegin();
-    return convert_encoding_into<DesiredStringType>(it, value.cend(), out);
-}
-
-//==================================================================================================
-template <typename StringType>
-template <typename DesiredStringType, typename IteratorType, typename OutputIteratorType>
-bool BasicStringUnicode<StringType>::convert_encoding_into(
-    IteratorType &it,
-    const IteratorType &end,
-    OutputIteratorType out)
 {
     using DesiredUnicodeType = BasicStringUnicode<DesiredStringType>;
 
+    auto it = value.cbegin();
+    const auto end = value.cend();
+
     while (it != end)
     {
         if (auto codepoint = decode_codepoint(it, end); codepoint)