Use new Unicode conversion helper where appropriate

Author: trflynn89

fly/types/string/detail/string_formatter.hpp

@@ -601,10 +601,7 @@ void BasicStringFormatter<StringType, ParameterTypes...>::append_string(
         using unicode = BasicStringUnicode<string_like_type>;
         view_like_type view(value);
 
-        auto it = view.cbegin();
-        const auto end = view.cend();
-
-        if (auto converted = unicode::template convert_encoding<StringType>(it, end); converted)
+        if (auto converted = unicode::template convert_encoding<StringType>(view); converted)
         {
             m_buffer.append(*std::move(converted), 0, max_width);
         }

fly/types/string/detail/string_streamer.hpp

@@ -212,24 +212,22 @@ template <typename T>
 void BasicStringStreamer<StringType>::stream_string(ostream_type &stream, T &&value)
 {
     using string_like_type = detail::is_like_supported_string_t<T>;
-    using string_like_traits = BasicStringTraits<string_like_type>;
 
     if constexpr (std::is_same_v<streamed_type, string_like_type>)
     {
         stream << value;
     }
     else
     {
+        using string_like_traits = BasicStringTraits<string_like_type>;
+        using string_like_view = typename string_like_traits::view_type;
         using unicode = BasicStringUnicode<string_like_type>;
-        using streamer = BasicStringStreamer<streamed_type>;
 
-        typename string_like_traits::view_type view(std::forward<T>(value));
-        auto it = view.cbegin();
-        const auto end = view.cend();
+        string_like_view view(std::forward<T>(value));
 
-        if (auto converted = unicode::template convert_encoding<streamed_type>(it, end); converted)
+        if (auto converted = unicode::template convert_encoding<streamed_type>(view); converted)
         {
-            streamer::stream_value(stream, *std::move(converted));
+            stream << *std::move(converted);
         }
     }
 }

fly/types/string/string.hpp

@@ -943,30 +943,17 @@ template <typename StringType>
 template <typename T>
 std::optional<T> BasicString<StringType>::convert(const StringType &value)
 {
-    using U = std::decay_t<T>;
-
-    if constexpr (detail::is_supported_string_v<U>)
+    if constexpr (detail::is_supported_string_v<T>)
     {
-        auto it = value.cbegin();
-        const auto end = value.cend();
-
-        if (auto result = unicode::template convert_encoding<U>(it, end); result)
-        {
-            return static_cast<T>(*result);
-        }
-
-        return std::nullopt;
+        return unicode::template convert_encoding<T>(value);
     }
     else if constexpr (std::is_same_v<char_type, char>)
     {
         return detail::BasicStringConverter<StringType, T>::convert(value);
     }
     else
     {
-        auto it = value.cbegin();
-        const auto end = value.cend();
-
-        if (auto result = unicode::template convert_encoding<std::string>(it, end); result)
+        if (auto result = unicode::template convert_encoding<std::string>(value); result)
         {
             return detail::BasicStringConverter<std::string, T>::convert(*result);
         }