Remove unused BasicStringStreamer functionality

BinaryFacet, streaming values with a preferred presentation types, and
streaming strings with a maximum width are no longer used.

Author: trflynn89

fly/types/string/detail/string_streamer.hpp

@@ -5,7 +5,6 @@
 #include "fly/types/string/string_literal.hpp"
 
 #include <cctype>
-#include <cmath>
 #include <cstdint>
 #include <ios>
 #include <locale>
@@ -49,14 +48,14 @@ struct BasicStringStreamer
      * All other types are dropped.
      *
      * @tparam T The type of the value to stream.
-     * @tparam PreferredPresentationType If given, the type T will be cast to this type.
      *
      * @param stream The stream to insert the value into.
      * @param value The value to stream.
      */
-    template <typename T, typename PreferredPresentationType = T>
+    template <typename T>
     static void stream_value(ostream_type &stream, T &&value);
 
+private:
     /**
      * Stream a string-like value into the given stream. If the type corresponds to the stream type,
      * then the string is streamed as-is. Other string-like types are converted to the Unicode
@@ -66,10 +65,9 @@ struct BasicStringStreamer
      *
      * @param stream The stream to insert the value into.
      * @param value The string-like value to stream.
-     * @param max_string_length The maximum number of characters from the string to stream.
      */
     template <typename T>
-    static void stream_string(ostream_type &stream, T &&value, std::size_t max_string_length);
+    static void stream_string(ostream_type &stream, T &&value);
 };
 
 /**
@@ -186,85 +184,16 @@ class PositivePaddingFacet : public std::ctype<CharType>
     static constexpr const auto s_space = FLY_CHR(CharType, ' ');
 };
 
-/**
- * Helper facet to support BasicFormatSpecifier::Type::Binary. Overrides std::num_put::do_put for
- * all integral types to write a value in a binary format, respecting any specified stream width,
- * alignment, and alternate form.
- *
- * @author Timothy Flynn ([email protected])
- * @version January 3, 2021
- */
-template <typename CharType>
-class BinaryFacet : public std::num_put<CharType>
-{
-    using iter_type = typename std::num_put<CharType>::iter_type;
-
-protected:
-    iter_type
-    do_put(iter_type out, std::ios_base &stream, CharType fill, std::intmax_t value) const override;
-
-    iter_type do_put(iter_type out, std::ios_base &stream, CharType fill, std::uintmax_t value)
-        const override;
-
-private:
-    /**
-     * Concrete implementation of the facet. Writes the minimum number of bits required to represent
-     * the given value. If the stream's alternate form is specified, the bits are prefixed with
-     * either '0b' or '0B', depending on whether the stream has specified uppercase formatting.
-     * Space permitting, if a stream width is specified, padding is inserted using the provided fill
-     * character. The location on the padding depends on whether left, right, or internal alignment
-     * are specified.
-     */
-    template <typename T>
-    iter_type do_put_impl(iter_type out, std::ios_base &stream, CharType fill, T value) const;
-
-    /**
-     * Count the number of significant bits in the given value. This is the total number of bits in
-     * the value excluding any leading zero bits.
-     *
-     * @tparam T Type of the value. Must be an unsigned, integral type.
-     *
-     * @param value The value to count.
-     *
-     * @return The number of significant bits counted.
-     */
-    template <typename T>
-    static constexpr std::size_t count_bits(T value);
-
-    /**
-     * Potentially insert padding symbols into the output iterator.
-     */
-    void maybe_fill(
-        iter_type out,
-        std::ios_base &stream,
-        CharType fill,
-        std::ios_base::fmtflags alignment,
-        std::size_t bits) const;
-
-    static constexpr const auto s_zero = FLY_CHR(CharType, '0');
-    static constexpr const auto s_one = FLY_CHR(CharType, '1');
-    static constexpr const auto s_upper_b = FLY_CHR(CharType, 'B');
-    static constexpr const auto s_lower_b = FLY_CHR(CharType, 'b');
-};
-
 //==================================================================================================
 template <typename StringType>
-template <typename T, typename PreferredPresentationType>
+template <typename T>
 void BasicStringStreamer<StringType>::stream_value(ostream_type &stream, T &&value)
 {
     using U = std::remove_cvref_t<T>;
-    using P = std::remove_cvref_t<PreferredPresentationType>;
 
-    if constexpr (!std::is_same_v<U, P>)
-    {
-        if constexpr (std::is_convertible_v<U, P>)
-        {
-            stream << static_cast<PreferredPresentationType>(std::forward<T>(value));
-        }
-    }
-    else if constexpr (detail::is_like_supported_string_v<U>)
+    if constexpr (detail::is_like_supported_string_v<U>)
     {
-        stream_string(stream, std::forward<T>(value), StringType::npos);
+        stream_string(stream, std::forward<T>(value));
     }
     else if constexpr (detail::is_supported_character_v<T>)
     {
@@ -280,31 +209,27 @@ void BasicStringStreamer<StringType>::stream_value(ostream_type &stream, T &&val
 //==================================================================================================
 template <typename StringType>
 template <typename T>
-void BasicStringStreamer<StringType>::stream_string(
-    ostream_type &stream,
-    T &&value,
-    std::size_t max_string_length)
+void BasicStringStreamer<StringType>::stream_string(ostream_type &stream, T &&value)
 {
     using string_like_type = detail::is_like_supported_string_t<T>;
     using string_like_traits = BasicStringTraits<string_like_type>;
 
-    typename string_like_traits::view_type view(std::forward<T>(value));
-
     if constexpr (std::is_same_v<streamed_type, string_like_type>)
     {
-        stream << view.substr(0, max_string_length);
+        stream << value;
     }
     else
     {
         using unicode = BasicStringUnicode<string_like_type>;
         using streamer = BasicStringStreamer<streamed_type>;
 
+        typename string_like_traits::view_type view(std::forward<T>(value));
         auto it = view.cbegin();
         const auto end = view.cend();
 
         if (auto converted = unicode::template convert_encoding<streamed_type>(it, end); converted)
         {
-            streamer::stream_string(stream, *std::move(converted), max_string_length);
+            streamer::stream_value(stream, *std::move(converted));
         }
     }
 }
@@ -417,100 +342,4 @@ PositivePaddingFacet<CharType>::do_widen(const char *begin, const char *end, Cha
     return end;
 }
 
-//==================================================================================================
-template <typename CharType>
-inline auto BinaryFacet<CharType>::do_put(
-    iter_type out,
-    std::ios_base &stream,
-    CharType fill,
-    std::intmax_t value) const -> iter_type
-{
-    return do_put_impl(out, stream, fill, value);
-}
-
-//==================================================================================================
-template <typename CharType>
-inline auto BinaryFacet<CharType>::do_put(
-    iter_type out,
-    std::ios_base &stream,
-    CharType fill,
-    std::uintmax_t value) const -> iter_type
-{
-    return do_put_impl(out, stream, fill, value);
-}
-
-//==================================================================================================
-template <typename CharType>
-template <typename T>
-auto BinaryFacet<CharType>::do_put_impl(
-    iter_type out,
-    std::ios_base &stream,
-    CharType fill,
-    T value) const -> iter_type
-{
-    using unsigned_type = std::make_unsigned_t<T>;
-
-    const auto unsigned_value = static_cast<unsigned_type>(value);
-    const auto bits = count_bits(unsigned_value);
-
-    maybe_fill(out, stream, fill, std::ios_base::right, bits);
-
-    if (stream.flags() & std::ios_base::showbase)
-    {
-        *out++ = s_zero;
-        *out++ = (stream.flags() & std::ios_base::uppercase) ? s_upper_b : s_lower_b;
-    }
-
-    maybe_fill(out, stream, fill, std::ios_base::internal, bits);
-
-    for (std::size_t bit = bits; bit > 0; --bit)
-    {
-        *out++ = ((unsigned_value >> (bit - 1)) & 0x1) ? s_one : s_zero;
-    }
-
-    maybe_fill(out, stream, fill, std::ios_base::left, bits);
-
-    return out;
-}
-
-//==================================================================================================
-template <typename CharType>
-template <typename T>
-inline constexpr std::size_t BinaryFacet<CharType>::count_bits(T value)
-{
-    static_assert(
-        std::is_unsigned_v<T> && std::is_integral_v<T>,
-        "An unsigned integral type is required for count_bits");
-
-    std::size_t bits = 0;
-
-    do
-    {
-        ++bits;
-    } while ((value >>= 1) != 0);
-
-    return bits;
-}
-
-//==================================================================================================
-template <typename CharType>
-void BinaryFacet<CharType>::maybe_fill(
-    iter_type out,
-    std::ios_base &stream,
-    CharType fill,
-    std::ios_base::fmtflags alignment,
-    std::size_t bits) const
-{
-    if ((stream.flags() & std::ios_base::adjustfield) == alignment)
-    {
-        std::streamsize fill_bits = stream.width() - static_cast<std::streamsize>(bits);
-        fill_bits -= (stream.flags() & std::ios_base::showbase) ? 2 : 0;
-
-        for (std::streamsize i = 0; i < fill_bits; ++i)
-        {
-            *out++ = fill;
-        }
-    }
-}
-
 } // namespace fly::detail