Skip to content

Commit 0720064

Browse files
committed
Move configuration library to fly::config namespace
1 parent fa1f6a5 commit 0720064

11 files changed

+34
-32
lines changed

fly/coders/coder_config.hpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ namespace fly {
1414
* @author Timothy Flynn ([email protected])
1515
* @version July 7, 2019
1616
*/
17-
class CoderConfig : public Config
17+
class CoderConfig : public fly::config::Config
1818
{
1919
public:
2020
static constexpr const char *identifier = "coder";

fly/config/config.cpp

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
#include "fly/config/config.hpp"
22

3-
namespace fly {
3+
namespace fly::config {
44

55
//==================================================================================================
66
void Config::update(const Json &values)
@@ -9,4 +9,4 @@ void Config::update(const Json &values)
99
m_values = values;
1010
}
1111

12-
} // namespace fly
12+
} // namespace fly::config

fly/config/config.hpp

+2-2
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
#include <shared_mutex>
66
#include <string>
77

8-
namespace fly {
8+
namespace fly::config {
99

1010
/**
1111
* Class to hold a set of related configuration values.
@@ -68,4 +68,4 @@ T Config::get_value(const std::string &name, T def) const
6868
return def;
6969
}
7070

71-
} // namespace fly
71+
} // namespace fly::config

fly/config/config_manager.cpp

+4-4
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
#include <filesystem>
1010
#include <functional>
1111

12-
namespace fly {
12+
namespace fly::config {
1313

1414
//==================================================================================================
1515
std::shared_ptr<ConfigManager> ConfigManager::create(
@@ -49,11 +49,11 @@ ConfigManager::ConfigManager(
4949
switch (file_type)
5050
{
5151
case ConfigFileType::Ini:
52-
m_parser = std::make_unique<IniParser>();
52+
m_parser = std::make_unique<fly::IniParser>();
5353
break;
5454

5555
case ConfigFileType::Json:
56-
m_parser = std::make_unique<JsonParser>();
56+
m_parser = std::make_unique<fly::JsonParser>();
5757
break;
5858

5959
default:
@@ -158,4 +158,4 @@ void ConfigManager::update_config()
158158
}
159159
}
160160

161-
} // namespace fly
161+
} // namespace fly::config

fly/config/config_manager.hpp

+9-7
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,10 @@
1212
#include <string>
1313
#include <type_traits>
1414

15+
namespace fly {
16+
class Parser;
17+
} // namespace fly
18+
1519
namespace fly::path {
1620
class PathMonitor;
1721
} // namespace fly::path
@@ -20,9 +24,7 @@ namespace fly::task {
2024
class SequencedTaskRunner;
2125
} // namespace fly::task
2226

23-
namespace fly {
24-
25-
class Parser;
27+
namespace fly::config {
2628

2729
/**
2830
* Class to create and manage a set of configurations.
@@ -69,7 +71,7 @@ class ConfigManager : public std::enable_shared_from_this<ConfigManager>
6971
/**
7072
* Create a configuration object, or if one with the given type's name exists, fetch it.
7173
*
72-
* @tparam T Config type (must derive from or be fly::Config).
74+
* @tparam T Config type (must derive from or be fly::config::Config).
7375
*
7476
* @return A reference to the created/found configuration.
7577
*/
@@ -111,8 +113,8 @@ class ConfigManager : public std::enable_shared_from_this<ConfigManager>
111113
std::shared_ptr<fly::task::SequencedTaskRunner> m_task_runner;
112114

113115
std::shared_ptr<fly::path::PathMonitor> m_monitor;
114-
std::unique_ptr<Parser> m_parser;
115-
Json m_values;
116+
std::unique_ptr<fly::Parser> m_parser;
117+
fly::Json m_values;
116118

117119
const std::filesystem::path m_path;
118120

@@ -163,4 +165,4 @@ std::shared_ptr<T> ConfigManager::create_config()
163165
return config;
164166
}
165167

166-
} // namespace fly
168+
} // namespace fly::config

fly/logger/logger_config.hpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ namespace fly {
1313
* @author Timothy Flynn ([email protected])
1414
* @version July 18, 2016
1515
*/
16-
class LoggerConfig : public Config
16+
class LoggerConfig : public fly::config::Config
1717
{
1818
public:
1919
static constexpr const char *identifier = "logger";

fly/net/network_config.hpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ namespace fly::net {
1313
* @author Timothy Flynn ([email protected])
1414
* @version March 6, 2021
1515
*/
16-
class NetworkConfig : public fly::Config
16+
class NetworkConfig : public fly::config::Config
1717
{
1818
public:
1919
static constexpr const char *identifier = "network";

fly/path/path_config.hpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ namespace fly::path {
1212
* @author Timothy Flynn ([email protected])
1313
* @version August 12, 2018
1414
*/
15-
class PathConfig : public Config
15+
class PathConfig : public fly::config::Config
1616
{
1717
public:
1818
static constexpr const char *identifier = "path";

fly/system/system_config.hpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ namespace fly::system {
1212
* @author Timothy Flynn ([email protected])
1313
* @version August 12, 2018
1414
*/
15-
class SystemConfig : public Config
15+
class SystemConfig : public fly::config::Config
1616
{
1717
public:
1818
static constexpr const char *identifier = "system";

test/config/config_manager.cpp

+9-9
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ class TestPathConfig : public fly::path::PathConfig
3838
/**
3939
* Badly written config class which uses the same identifier as fly::test::TestConfig.
4040
*/
41-
class BadConfig : public fly::Config
41+
class BadConfig : public fly::config::Config
4242
{
4343
public:
4444
static constexpr const char *identifier = fly::test::TestConfig::identifier;
@@ -53,9 +53,9 @@ CATCH_TEST_CASE("ConfigManager", "[config]")
5353
fly::test::PathUtil::ScopedTempDirectory config_path;
5454
std::filesystem::path config_file = config_path.file();
5555

56-
auto config_manager = fly::ConfigManager::create(
56+
auto config_manager = fly::config::ConfigManager::create(
5757
task_runner,
58-
fly::ConfigManager::ConfigFileType::Json,
58+
fly::config::ConfigManager::ConfigFileType::Json,
5959
config_file);
6060
CATCH_REQUIRE(config_manager);
6161

@@ -64,24 +64,24 @@ CATCH_TEST_CASE("ConfigManager", "[config]")
6464

6565
CATCH_SECTION("Config managers can be started for all file types")
6666
{
67-
config_manager = fly::ConfigManager::create(
67+
config_manager = fly::config::ConfigManager::create(
6868
task_runner,
69-
fly::ConfigManager::ConfigFileType::Ini,
69+
fly::config::ConfigManager::ConfigFileType::Ini,
7070
config_file);
7171
CATCH_CHECK(config_manager);
7272

73-
config_manager = fly::ConfigManager::create(
73+
config_manager = fly::config::ConfigManager::create(
7474
task_runner,
75-
fly::ConfigManager::ConfigFileType::Json,
75+
fly::config::ConfigManager::ConfigFileType::Json,
7676
config_file);
7777
CATCH_CHECK(config_manager);
7878
}
7979

8080
CATCH_SECTION("Cannot start a config manager of an unsupported file type")
8181
{
82-
config_manager = fly::ConfigManager::create(
82+
config_manager = fly::config::ConfigManager::create(
8383
task_runner,
84-
static_cast<fly::ConfigManager::ConfigFileType>(-1),
84+
static_cast<fly::config::ConfigManager::ConfigFileType>(-1),
8585
config_file);
8686
CATCH_CHECK_FALSE(config_manager);
8787
}

test/config/test_config.hpp

+3-3
Original file line numberDiff line numberDiff line change
@@ -11,20 +11,20 @@ namespace fly::test {
1111
* A pseudo config class to provide public access to Config methods. Only meant to be used by unit
1212
* tests.
1313
*/
14-
class TestConfig : public fly::Config
14+
class TestConfig : public fly::config::Config
1515
{
1616
public:
1717
static constexpr const char *identifier = "config";
1818

1919
template <typename T>
2020
T get_value(const std::string &name, T def) const
2121
{
22-
return fly::Config::get_value(name, def);
22+
return fly::config::Config::get_value(name, def);
2323
}
2424

2525
void update(const fly::Json &values)
2626
{
27-
fly::Config::update(values);
27+
fly::config::Config::update(values);
2828
}
2929
};
3030

0 commit comments

Comments
 (0)