fixup! feat: Support Ethereum EIP-712 Sign Typed Data

aloisklink · aloisklink · commit af80c5c6e35e · 2021-12-18T23:55:18.000Z
Cleanup BigNumber.js usage.
diff --git a/src/js/core/methods/helpers/ethereumSignTypedData.js b/src/js/core/methods/helpers/ethereumSignTypedData.js
@@ -64,7 +64,7 @@ function twosComplement(number: BigNumber, bytes: number): BigNumber {
     if (bigNumber.isPositive()) {
         return bigNumber;
     }
-    return bigNumber.minus(minValue).plus(minValue.negated());
+    return bigNumber.minus(minValue).minus(minValue);
 }
 
 function intToHex(
@@ -77,7 +77,7 @@ function intToHex(
     if (signed) {
         bigNumber = twosComplement(bigNumber, bytes);
     }
-    if (bigNumber.isNegative(0)) {
+    if (bigNumber.isNegative()) {
         throw ERRORS.TypedError(
             'Method_InvalidParameter',
             `Cannot convert negative number to unsigned interger: ${number}`,

Original file line number	Diff line number	Diff line change
`@@ -64,7 +64,7 @@ function twosComplement(number: BigNumber, bytes: number): BigNumber {`
`64`	`64`	`if (bigNumber.isPositive()) {`
`65`	`65`	`return bigNumber;`
`66`	`66`	`}`
`67`		`- return bigNumber.minus(minValue).plus(minValue.negated());`
	`67`	`+ return bigNumber.minus(minValue).minus(minValue);`
`68`	`68`	`}`
`69`	`69`
`70`	`70`	`function intToHex(`
`@@ -77,7 +77,7 @@ function intToHex(`
`77`	`77`	`if (signed) {`
`78`	`78`	`bigNumber = twosComplement(bigNumber, bytes);`
`79`	`79`	`}`
`80`		`- if (bigNumber.isNegative(0)) {`
	`80`	`+ if (bigNumber.isNegative()) {`
`81`	`81`	`throw ERRORS.TypedError(`
`82`	`82`	`'Method_InvalidParameter',`
`83`	`83`	`Cannot convert negative number to unsigned interger: ${number}`,