Skip to content

Commit c1d78bc

Browse files
ashieashie
committed
rspec: Replace pending with skip
In our cases we should use later one as of RSpec 3: https://rubydoc.info/gems/rspec-core/RSpec/Core/Pending Signed-off-by: Takuro Ashie <[email protected]>
1 parent cd6c0d3 commit c1d78bc

File tree

4 files changed

+20
-20
lines changed

4 files changed

+20
-20
lines changed

‎spec/daemon_logger_spec.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,7 @@
150150
end
151151

152152
it 'inter-process locking on rotation' do
153-
pending "fork is not implemented in Windows" if ServerEngine.windows?
153+
skip "fork is not implemented in Windows" if ServerEngine.windows?
154154

155155
log = DaemonLogger.new("tmp/se4.log", level: 'trace', log_rotate_age: 3, log_rotate_size: 10)
156156
r, w = IO.pipe
@@ -175,7 +175,7 @@
175175
end
176176

177177
it 'reopen log when path is renamed' do
178-
pending "rename isn't supported on windows" if ServerEngine.windows?
178+
skip "rename isn't supported on windows" if ServerEngine.windows?
179179

180180
log = DaemonLogger.new("tmp/rotate.log", { level: 'info', log_rotate_age: 0 })
181181

‎spec/daemon_spec.rb

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
end
1212

1313
it 'run and graceful stop by signal' do
14-
pending "not supported signal base commands on Windows" if ServerEngine.windows?
14+
skip "not supported signal base commands on Windows" if ServerEngine.windows?
1515

1616
dm = Daemon.new(TestServer, TestWorker, daemonize: true, pid_path: "tmp/pid", command_sender: "signal")
1717
dm.main
@@ -33,7 +33,7 @@
3333
end
3434

3535
it 'signals' do
36-
pending "not supported signal base commands on Windows" if ServerEngine.windows?
36+
skip "not supported signal base commands on Windows" if ServerEngine.windows?
3737
dm = Daemon.new(TestServer, TestWorker, daemonize: true, pid_path: "tmp/pid", command_sender: "signal")
3838
dm.main
3939

@@ -112,7 +112,7 @@
112112
end
113113

114114
it 'exits with status 0 when it was stopped normally' do
115-
pending "worker type process(fork) cannot be used in Windows" if ServerEngine.windows?
115+
skip "worker type process(fork) cannot be used in Windows" if ServerEngine.windows?
116116
dm = Daemon.new(
117117
TestServer,
118118
TestWorker,
@@ -135,7 +135,7 @@
135135
end
136136

137137
it 'exits with status of workers if worker exits with status specified in unrecoverable_exit_codes, without supervisor' do
138-
pending "worker type process(fork) cannot be used in Windows" if ServerEngine.windows?
138+
skip "worker type process(fork) cannot be used in Windows" if ServerEngine.windows?
139139

140140
dm = Daemon.new(
141141
TestServer,
@@ -159,7 +159,7 @@
159159
end
160160

161161
it 'exits with status of workers if worker exits with status specified in unrecoverable_exit_codes, with supervisor' do
162-
pending "worker type process(fork) cannot be used in Windows" if ServerEngine.windows?
162+
skip "worker type process(fork) cannot be used in Windows" if ServerEngine.windows?
163163

164164
dm = Daemon.new(
165165
TestServer,

‎spec/multi_process_server_spec.rb

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
end
1818

1919
it 'scale up' do
20-
pending "Windows environment does not support fork" if ServerEngine.windows? && impl_class == ServerEngine::MultiProcessServer
20+
skip "Windows environment does not support fork" if ServerEngine.windows? && impl_class == ServerEngine::MultiProcessServer
2121

2222
config = {
2323
workers: 2,
@@ -50,7 +50,7 @@
5050
end
5151

5252
it 'scale down' do
53-
pending "Windows environment does not support fork" if ServerEngine.windows? && impl_class == ServerEngine::MultiProcessServer
53+
skip "Windows environment does not support fork" if ServerEngine.windows? && impl_class == ServerEngine::MultiProcessServer
5454

5555
config = {
5656
workers: 2,
@@ -98,7 +98,7 @@
9898
end
9999

100100
it 'raises SystemExit when all workers exit with specified code by unrecoverable_exit_codes' do
101-
pending "Windows environment does not support fork" if ServerEngine.windows? && impl_class == ServerEngine::MultiProcessServer
101+
skip "Windows environment does not support fork" if ServerEngine.windows? && impl_class == ServerEngine::MultiProcessServer
102102

103103
config = {
104104
workers: 4,
@@ -127,7 +127,7 @@
127127
end
128128

129129
it 'raises SystemExit immediately when a worker exits if stop_immediately_at_unrecoverable_exit specified' do
130-
pending "Windows environment does not support fork" if ServerEngine.windows? && impl_class == ServerEngine::MultiProcessServer
130+
skip "Windows environment does not support fork" if ServerEngine.windows? && impl_class == ServerEngine::MultiProcessServer
131131

132132
config = {
133133
workers: 4,
@@ -172,7 +172,7 @@
172172
end
173173

174174
it 'stop' do
175-
pending "Windows environment does not support fork" if ServerEngine.windows?
175+
skip "Windows environment does not support fork" if ServerEngine.windows?
176176

177177
config = {
178178
workers: 1,
@@ -197,7 +197,7 @@
197197
end
198198

199199
it 'non zero exit status' do
200-
pending "Windows environment does not support fork" if ServerEngine.windows?
200+
skip "Windows environment does not support fork" if ServerEngine.windows?
201201

202202
config = {
203203
workers: 1,
@@ -232,7 +232,7 @@ def initialize
232232
end
233233

234234
it 'zero exit status' do
235-
pending "Windows environment does not support fork" if ServerEngine.windows?
235+
skip "Windows environment does not support fork" if ServerEngine.windows?
236236

237237
config = {
238238
workers: 1,

‎spec/supervisor_spec.rb

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ def start_daemon(**config)
9090
context "when using #{sender} as command_sender" do
9191

9292
it 'start and graceful stop' do
93-
pending 'not supported on Windows' if ServerEngine.windows? && sender == 'signal'
93+
skip 'not supported on Windows' if ServerEngine.windows? && sender == 'signal'
9494

9595
sv, t = start_supervisor(command_sender: sender)
9696

@@ -113,7 +113,7 @@ def start_daemon(**config)
113113
end
114114

115115
it 'immediate stop' do
116-
pending 'not supported on Windows' if ServerEngine.windows? && sender == 'signal'
116+
skip 'not supported on Windows' if ServerEngine.windows? && sender == 'signal'
117117

118118
sv, t = start_supervisor(command_sender: sender)
119119

@@ -131,7 +131,7 @@ def start_daemon(**config)
131131
end
132132

133133
it 'graceful restart' do
134-
pending 'not supported on Windows' if ServerEngine.windows? && sender == 'signal'
134+
skip 'not supported on Windows' if ServerEngine.windows? && sender == 'signal'
135135

136136
sv, t = start_supervisor(command_sender: sender)
137137

@@ -155,7 +155,7 @@ def start_daemon(**config)
155155
end
156156

157157
it 'immediate restart' do
158-
pending 'not supported on Windows' if ServerEngine.windows? && sender == 'signal'
158+
skip 'not supported on Windows' if ServerEngine.windows? && sender == 'signal'
159159

160160
sv, t = start_supervisor(command_sender: sender)
161161

@@ -179,7 +179,7 @@ def start_daemon(**config)
179179
end
180180

181181
it 'reload' do
182-
pending 'not supported on Windows' if ServerEngine.windows? && sender == 'signal'
182+
skip 'not supported on Windows' if ServerEngine.windows? && sender == 'signal'
183183

184184
sv, t = start_supervisor(command_sender: sender)
185185

@@ -200,7 +200,7 @@ def start_daemon(**config)
200200
# TODO detach
201201

202202
it 'auto restart in limited ratio' do
203-
pending 'not supported on Windows' if ServerEngine.windows? && sender == 'signal'
203+
skip 'not supported on Windows' if ServerEngine.windows? && sender == 'signal'
204204

205205
RR.stub(ServerEngine).dump_uncaught_error
206206

0 commit comments

Comments
 (0)