Ensure ruby bits are checked

so that syntax errors can't make it into master

Author: meatballhat

.gitignore

@@ -7,7 +7,6 @@
 
 .env
 .envrc
-.ruby-version
 .terraform/
 /tmp/
 assets/*.tar.bz2

.rubocop.yml

@@ -0,0 +1,10 @@
+inherit_from: .rubocop_todo.yml
+
+AllCops:
+  TargetRubyVersion: 2.5
+
+Style/Documentation:
+  Enabled: false
+
+Style/AccessModifierDeclarations:
+  EnforcedStyle: inline

.rubocop_todo.yml

@@ -0,0 +1,62 @@
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2018-11-30 09:10:04 -0500 using RuboCop version 0.60.0.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 22
+Metrics/AbcSize:
+  Max: 80
+
+# Offense count: 2
+# Configuration parameters: CountComments, ExcludedMethods.
+# ExcludedMethods: refine
+Metrics/BlockLength:
+  Max: 30
+
+# Offense count: 1
+# Configuration parameters: CountComments.
+Metrics/ClassLength:
+  Max: 138
+
+# Offense count: 1
+Metrics/CyclomaticComplexity:
+  Max: 7
+
+# Offense count: 27
+# Configuration parameters: CountComments, ExcludedMethods.
+Metrics/MethodLength:
+  Max: 81
+
+# Offense count: 4
+# Configuration parameters: Blacklist.
+# Blacklist: (?-mix:(^|\s)(EO[A-Z]{1}|END)(\s|$))
+Naming/HeredocDelimiterNaming:
+  Exclude:
+    - 'bin/gcloud-nats-by-zone'
+    - 'bin/generate-latest-gce-images'
+    - 'bin/write-config-files'
+
+# Offense count: 4
+Style/DoubleNegation:
+  Exclude:
+    - 'bin/gce-export-net'
+    - 'bin/gce-export-workers'
+    - 'bin/gce-import-net'
+    - 'bin/gce-import-workers'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, AllowInnerSlashes.
+# SupportedStyles: slashes, percent_r, mixed
+Style/RegexpLiteral:
+  Exclude:
+    - 'bin/travis-worker-verify-config'
+
+# Offense count: 7
+# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
+# URISchemes: http, https
+Metrics/LineLength:
+  Max: 145

.ruby-version

@@ -0,0 +1 @@
+2.5.3

.travis.yml

@@ -1,5 +1,4 @@
 language: bash
-rvm: 2.4.2
 dist: xenial
 group: edge
 sudo: required
@@ -12,6 +11,7 @@ env:
   - PATH="${HOME}/bin:${PATH}"
   - TMPDIR="${TMPDIR:-/tmp}"
 before_install:
+- rvm use --install --fuzzy "$(cat .ruby-version)"
 - eval "$(gimme 1.11.1)"
 - make deps
 script:

Gemfile

@@ -0,0 +1,5 @@
+# frozen_string_literal: true
+
+source 'https://rubygems.org'
+
+gem 'rubocop'

Gemfile.lock

@@ -0,0 +1,29 @@
+GEM
+  remote: https://rubygems.org/
+  specs:
+    ast (2.4.0)
+    jaro_winkler (1.5.1)
+    parallel (1.12.1)
+    parser (2.5.3.0)
+      ast (~> 2.4.0)
+    powerpack (0.1.2)
+    rainbow (3.0.0)
+    rubocop (0.60.0)
+      jaro_winkler (~> 1.5.1)
+      parallel (~> 1.10)
+      parser (>= 2.5, != 2.5.1.1)
+      powerpack (~> 0.1)
+      rainbow (>= 2.2.2, < 4.0)
+      ruby-progressbar (~> 1.7)
+      unicode-display_width (~> 1.4.0)
+    ruby-progressbar (1.10.0)
+    unicode-display_width (1.4.0)
+
+PLATFORMS
+  ruby
+
+DEPENDENCIES
+  rubocop
+
+BUNDLED WITH
+   1.17.1

Makefile

@@ -6,6 +6,7 @@ PROVIDER_TRAVIS_URL := github.com/travis-ci/terraform-provider-travis
 
 DEPS := \
 	.ensure-provider-travis \
+	.ensure-rubocop \
 	.ensure-shellcheck \
 	.ensure-shfmt \
 	.ensure-terraforms \
@@ -43,6 +44,11 @@ deps: $(DEPS)
 			./bin/ensure-terraform $${tf_version}; \
 		done
 
+.PHONY: .ensure-rubocop
+.ensure-rubocop:
+	bundle version &>/dev/null || gem install bundler
+	bundle exec rubocop --version &>/dev/null || bundle install
+
 .PHONY: .ensure-shellcheck
 .ensure-shellcheck:
 	if [[ ! -x "$(HOME)/bin/shellcheck" ]]; then \

bin/build-cache-configure

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 require 'json'
 require 'optparse'
@@ -10,7 +11,7 @@ def main
     apps: [],
     fqdn: '',
     heroku_api_hostname: 'api.heroku.com',
-    heroku_api_key: ENV.fetch('HEROKU_API_KEY', '').strip,
+    heroku_api_key: ENV.fetch('HEROKU_API_KEY', '').strip
   }
 
   OptionParser.new do |opts|
@@ -35,8 +36,8 @@ def main
     ) { |v| options[:heroku_api_key] = v.strip }
   end.parse!
 
-  fail 'Missing HEROKU_API_KEY' if options[:heroku_api_key].empty?
-  fail 'No apps specified' if options[:apps].empty?
+  raise 'Missing HEROKU_API_KEY' if options[:heroku_api_key].empty?
+  raise 'No apps specified' if options[:apps].empty?
 
   heroku = HerokuClient.new(
     api_key: options.fetch(:heroku_api_key),

bin/env-url-to-parts

@@ -1,4 +1,6 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
+
 require 'uri'
 
 def main(argv = ARGV)
@@ -8,7 +10,7 @@ def main(argv = ARGV)
 
   parsed = URI(ENV.fetch(url_varname))
 
-  %w(scheme user password host port path query).each do |part|
+  %w[scheme user password host port path query].each do |part|
     basename = "#{url_varname}_#{part.upcase}_#{suffix}"
     File.open(File.join(out_dir, basename), 'w') do |f|
       f.puts parsed.send(part).to_s + "\n"

bin/format-images-json

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 require 'json'
 

bin/format-public-ip-addresses

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 require 'json'
 require 'net/http'

bin/gce-export-net

@@ -1,11 +1,13 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
+
 require 'optparse'
 
 def main
   options = {
     module_name: ENV.fetch('MODULE_NAME', 'gce_project_1'),
     noop: false,
-    terraform: ENV.fetch('TERRAFORM', 'terraform'),
+    terraform: ENV.fetch('TERRAFORM', 'terraform')
   }
 
   OptionParser.new do |opts|
@@ -50,7 +52,7 @@ def main
     ].map { |r| "module.#{module_name}.#{r}" }
   )
 
-  $stderr.puts("---> #{command.join(' ')}")
+  warn("---> #{command.join(' ')}")
   system(*command) unless noop
 
   0

bin/gce-export-workers

@@ -1,16 +1,18 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
+
 require 'optparse'
 
 def main
   options = {
     counts: {
       com: Integer(ENV.fetch('COUNT_COM', '0')),
-      org: Integer(ENV.fetch('COUNT_ORG', '0')),
+      org: Integer(ENV.fetch('COUNT_ORG', '0'))
     },
     module_name: ENV.fetch('MODULE_NAME', 'gce_project_1'),
     noop: false,
     terraform: ENV.fetch('TERRAFORM', 'terraform'),
-    zones: ENV.fetch('ZONES', 'a,b,c,f').split(',').map(&:strip),
+    zones: ENV.fetch('ZONES', 'a,b,c,f').split(',').map(&:strip)
   }
 
   OptionParser.new do |opts|
@@ -59,7 +61,7 @@ def main
     end
   end
 
-  $stderr.puts("---> #{command.join(' ')}")
+  warn("---> #{command.join(' ')}")
   system(*command) unless noop
 
   0

bin/gce-import-net

@@ -1,4 +1,6 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
+
 require 'optparse'
 
 def main
@@ -8,7 +10,7 @@ def main
     noop: false,
     project: ENV.fetch('PROJECT', 'notset'),
     region: ENV.fetch('REGION', 'us-central1'),
-    terraform: ENV.fetch('TERRAFORM', 'terraform'),
+    terraform: ENV.fetch('TERRAFORM', 'terraform')
   }
 
   OptionParser.new do |opts|
@@ -57,14 +59,15 @@ def main
     'google_compute_subnetwork.jobs_com' => "#{region}/jobs-com",
     'google_compute_subnetwork.jobs_org' => "#{region}/jobs-org",
     'google_compute_subnetwork.public' => "#{region}/public",
-    'google_compute_subnetwork.workers' => "#{region}/workers",
+    'google_compute_subnetwork.workers' => "#{region}/workers"
   }.each do |resource, importable|
     command = %W[
       #{terraform} import module.gce_net.#{resource} #{importable}
     ]
-    $stderr.puts("---> #{command.join(' ')}")
+    warn("---> #{command.join(' ')}")
     next if noop
-    system(*command) || $stderr.puts('---? already imported?')
+
+    system(*command) || warn('---? already imported?')
   end
 
   0

bin/gce-import-workers

@@ -1,11 +1,13 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
+
 require 'optparse'
 
 def main
   options = {
     counts: {
       com: Integer(ENV.fetch('COUNT_COM', '0')),
-      org: Integer(ENV.fetch('COUNT_ORG', '0')),
+      org: Integer(ENV.fetch('COUNT_ORG', '0'))
     },
     env: ENV.fetch('ENV', 'staging'),
     index: ENV.fetch('INDEX', '1'),
@@ -14,7 +16,7 @@ def main
     project: ENV.fetch('PROJECT', 'notset'),
     region: ENV.fetch('REGION', 'us-central1'),
     terraform: ENV.fetch('TERRAFORM', 'terraform'),
-    zones: ENV.fetch('ZONES', 'a,b,c,f').split(',').map(&:strip),
+    zones: ENV.fetch('ZONES', 'a,b,c,f').split(',').map(&:strip)
   }
 
   OptionParser.new do |opts|
@@ -70,7 +72,7 @@ def main
   zones = options.fetch(:zones)
 
   to_import = {
-    'heroku_app.gcloud_cleanup' => "gcloud-cleanup-#{env}-#{index}",
+    'heroku_app.gcloud_cleanup' => "gcloud-cleanup-#{env}-#{index}"
   }
 
   %i[com org].each do |site|
@@ -90,9 +92,10 @@ def main
     command = %W[
       #{terraform} import module.#{module_name}.#{resource} #{importable}
     ]
-    $stderr.puts("---> #{command.join(' ')}")
+    warn("---> #{command.join(' ')}")
     next if noop
-    system(*command) || $stderr.puts('---? already imported?')
+
+    system(*command) || warn('---? already imported?')
   end
 
   0