Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement modulo or remainder operation. #1510

Closed
zemelLeong opened this issue Mar 25, 2024 · 1 comment · Fixed by #2427
Closed

Implement modulo or remainder operation. #1510

zemelLeong opened this issue Mar 25, 2024 · 1 comment · Fixed by #2427
Labels
feature The feature request

Comments

@zemelLeong
Copy link

https://pytorch.org/docs/stable/generated/torch.remainder.html
@antimora antimora added the feature The feature request label Mar 25, 2024
@agelas agelas mentioned this issue Apr 9, 2024
Merged
2 tasks
@kantic kantic mentioned this issue May 5, 2024
Merged
2 tasks
@laggui laggui closed this as completed Aug 8, 2024
@laggui
Copy link
Member

laggui commented Aug 23, 2024

Accidentally closed this thinking we had full remainder support with the linked PRs, but actually this was only implemented for tensor % scalar. We still need element-wise remainder support.

@laggui laggui reopened this Aug 23, 2024
@med1844 med1844 mentioned this issue Oct 27, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature The feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add binary remainder for tensor med1844/burn
3 participants
@antimora @laggui @zemelLeong