Remove TODO in controllers/submariner/submariner_controller.go

tpantelis · tpantelis · commit 7ac72d1fe9d3 · 2024-07-26T12:33:16.000-04:00
"vthapar Add metrics-proxy status to Submariner CR so we can update it with daemonset status" Issue submariner-io#3169 created to track this. Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
diff --git a/controllers/submariner/submariner_controller.go b/controllers/submariner/submariner_controller.go
@@ -248,8 +248,6 @@ func (r *Reconciler) Reconcile(ctx context.Context, request reconcile.Request) (
 		return reconcile.Result{}, err
 	}
 
-	// TODO: vthapar Add metrics-proxy status to Submariner CR so we can update it with daemonset status
-
 	if loadBalancer != nil {
 		instance.Status.LoadBalancerStatus.Status = &loadBalancer.Status.LoadBalancer
 	} else {

Original file line number	Diff line number	Diff line change
`@@ -248,8 +248,6 @@ func (r *Reconciler) Reconcile(ctx context.Context, request reconcile.Request) (`
`248`	`248`	`return reconcile.Result{}, err`
`249`	`249`	`}`
`250`	`250`
`251`		`- // TODO: vthapar Add metrics-proxy status to Submariner CR so we can update it with daemonset status`
`252`		`-`
`253`	`251`	`if loadBalancer != nil {`
`254`	`252`	`instance.Status.LoadBalancerStatus.Status = &loadBalancer.Status.LoadBalancer`
`255`	`253`	`} else {`