Merge pull request #67 from touchlane/FramesLayout

Frames layout

Author: vasileuskivadzim

Example/Source/Controllers/CarouselController/Menu/CircularTitleScrollView.swift

@@ -85,16 +85,6 @@ class CarouselTitleScrollView: TitleScrollView<CarouselTitleItem> {
 
 private typealias PrivateCarouselTitleScrollView = CarouselTitleScrollView
 private extension PrivateCarouselTitleScrollView {
-    func activateBackgroundViewConstraints(view: UIView, position: CGFloat, width: CGFloat) {
-        var constraints: [NSLayoutConstraint] = []
-        constraints.append(view.topAnchor.constraint(equalTo: topAnchor, constant: itemOffsetTop + itemHeight))
-        let leading = view.leadingAnchor.constraint(equalTo: leadingAnchor, constant: position)
-        constraints.append(leading)
-        let width = view.widthAnchor.constraint(equalToConstant: width)
-        constraints.append(width)
-        NSLayoutConstraint.activate(constraints)
-    }
-    
     func activateConstraints(view: UIView, prevView: UIView?, isLast: Bool) {
         var constraints: [NSLayoutConstraint] = []
         constraints.append(view.topAnchor.constraint(equalTo: topAnchor, constant: itemOffsetTop))

Source/SlideContainerController.swift

@@ -10,44 +10,53 @@ import UIKit
 
 ///SlideContainerController do control for specific container view
 final class SlideContainerController {
-    private var internalView = UIView()
+    private var internalView = InternalView()
     private var isViewLoaded = false
 
     ///Property to indicate if target view mounted to container
     var hasContent: Bool {
-        return isViewLoaded
+        return self.isViewLoaded
     }
 
     ///Implements lazy load, add target view as subview to container view when needed and set hasContent = true
     func load(view: UIView) {
-        guard !isViewLoaded else {
+        guard !self.isViewLoaded else {
             return
         }
-        isViewLoaded = true
-        view.translatesAutoresizingMaskIntoConstraints = false
-        internalView.addSubview(view)
-        NSLayoutConstraint.activate([
-            view.topAnchor.constraint(equalTo: internalView.topAnchor),
-            view.leadingAnchor.constraint(equalTo: internalView.leadingAnchor),
-            view.bottomAnchor.constraint(equalTo: internalView.bottomAnchor),
-            view.trailingAnchor.constraint(equalTo: internalView.trailingAnchor)
-        ])
+        self.isViewLoaded = true
+        self.internalView.addSubview(view)
+        view.frame = self.internalView.bounds
     }
 
     ///Removes view from container and sets hasContent = false
     func unloadView() {
-        guard isViewLoaded else {
+        guard self.isViewLoaded else {
             return
         }
-        isViewLoaded = false
-        internalView.subviews.forEach({ $0.removeFromSuperview() })
+        self.isViewLoaded = false
+        self.internalView.subviews.forEach({ $0.removeFromSuperview() })
     }
 }
 
 ///Viewable protocol implementation
 private typealias ViewableImplementation = SlideContainerController
 extension ViewableImplementation: Viewable {
     var view: UIView {
-        return internalView
+        return self.internalView
+    }
+}
+
+///Internal view for SlideContainerController
+private final class InternalView: UIView {
+    private var oldSize: CGSize = .zero
+    
+    override func layoutSubviews() {
+        guard self.oldSize != self.bounds.size else {
+            return
+        }
+        super.layoutSubviews()
+        
+        self.subviews.first?.frame = self.bounds
+        self.oldSize = self.bounds.size
     }
 }

Source/SlideContainerView.swift

@@ -9,114 +9,35 @@
 import UIKit
 
 ///Represents container view for one page content
-final class SlideContainerView {
+final class SlideContainerView: UIView {
     private var internalView: UIView
-    private let containerView = UIView()
-    
-    ///Constraints for internal view, allow to change UI positioning for container view
-    var constraints = [NSLayoutConstraint]()
 
+    private var oldSize: CGSize = .zero
+
     /// - Parameter view: The view to show as content.
     init(view: UIView) {
-        containerView.clipsToBounds = true
-        containerView.translatesAutoresizingMaskIntoConstraints = false
-        containerView.addSubview(view)
-        NSLayoutConstraint.activate([
-            view.topAnchor.constraint(equalTo: containerView.topAnchor),
-            view.leadingAnchor.constraint(equalTo: containerView.leadingAnchor),
-            view.widthAnchor.constraint(equalTo: containerView.widthAnchor),
-            view.heightAnchor.constraint(equalTo: containerView.heightAnchor)
-        ])
-        internalView = view
+        self.internalView = view
+        super.init(frame: .zero)
+        self.clipsToBounds = true
+        self.addSubview(view)
     }
 
-    ///Sets container view frame width or height to 0,
-    ///internal view saves frame size to avoid unnecessary layout work
-    func hide(direction: SlideDirection) {
-        var removeConstraints: [NSLayoutConstraint] = []
-        var addConstraints: [NSLayoutConstraint] = []
-        
-        let layoutAttribute: NSLayoutConstraint.Attribute
-        let containerViewAnchor: NSLayoutDimension
-        let internalViewAnchor: NSLayoutDimension
-        let constraintConstant: CGFloat
-        switch direction {
-        case .horizontal:
-            layoutAttribute = .width
-            containerViewAnchor = containerView.widthAnchor
-            internalViewAnchor = internalView.widthAnchor
-            constraintConstant = containerView.frame.size.width
-        case .vertical:
-            layoutAttribute = .height
-            containerViewAnchor = containerView.heightAnchor
-            internalViewAnchor = internalView.heightAnchor
-            constraintConstant = containerView.frame.size.height
-        }
-        
-        guard let constraintIndex = constraints.index(where: { $0.firstAttribute == layoutAttribute }),
-            let viewConstraintIndex = containerView.constraints.index(where: { $0.firstAttribute == layoutAttribute }) else {
-            return
-        }
-        removeConstraints.append(constraints[constraintIndex])
-        constraints.remove(at: constraintIndex)
-        let constraint = containerViewAnchor.constraint(equalToConstant: 0)
-        addConstraints.append(constraint)
-        constraints.append(constraint)
-        
-        removeConstraints.append(containerView.constraints[viewConstraintIndex])
-        let viewConstraint = internalViewAnchor.constraint(equalToConstant: constraintConstant)
-        addConstraints.append(viewConstraint)
-        NSLayoutConstraint.deactivate(removeConstraints)
-        NSLayoutConstraint.activate(addConstraints)
+    required init?(coder aDecoder: NSCoder) {
+        fatalError("init(coder:) has not been implemented")
     }
 
-    ///Returns container view frame width or height to match superview frame
-    func show(direction: SlideDirection) {
-        guard let superView = containerView.superview else {
+    override func layoutSubviews() {
+        guard self.oldSize != self.bounds.size else {
             return
         }
-        var removeConstraints: [NSLayoutConstraint] = []
-        var addConstraints: [NSLayoutConstraint] = []
-        
-        let layoutAttribute: NSLayoutConstraint.Attribute
-        let containerViewAnchor: NSLayoutDimension
-        let internalViewAnchor: NSLayoutDimension
-        let superviewAnchor: NSLayoutDimension
-        switch direction {
-        case .horizontal:
-            layoutAttribute = .width
-            containerViewAnchor = containerView.widthAnchor
-            internalViewAnchor = internalView.widthAnchor
-            superviewAnchor = superView.widthAnchor
-        case .vertical:
-            layoutAttribute = .height
-            containerViewAnchor = containerView.heightAnchor
-            internalViewAnchor = internalView.heightAnchor
-            superviewAnchor = superView.heightAnchor
-        }
 
-        guard let constraintIndex = constraints.index(where: { $0.firstAttribute == layoutAttribute }),
-            let viewConstraintIndex = internalView.constraints.index(where: { $0.firstAttribute == layoutAttribute }) else {
+        super.layoutSubviews()
+
+        guard !self.isHidden else {
             return
         }
-        removeConstraints.append(constraints[constraintIndex])
-        constraints.remove(at: constraintIndex)
-        let constraint = containerViewAnchor.constraint(equalTo: superviewAnchor)
-        addConstraints.append(constraint)
-        constraints.append(constraint)
 
-        removeConstraints.append(internalView.constraints[viewConstraintIndex])
-        let viewConstraint = internalViewAnchor.constraint(equalTo: containerViewAnchor)
-        addConstraints.append(viewConstraint)
-        NSLayoutConstraint.deactivate(removeConstraints)
-        NSLayoutConstraint.activate(addConstraints)
-    }
-}
-
-///Viewable protocol implementation
-private typealias ViewableImplementation = SlideContainerView
-extension ViewableImplementation: Viewable {
-    var view: UIView {
-        return containerView
+        self.internalView.frame = self.bounds
+        self.oldSize = self.bounds.size
     }
 }

Source/SlideContentController.swift

@@ -32,15 +32,14 @@ final class SlideContentController {
         didSet {
             if isCarousel {
                 addEdgeContainersIfNeeded()
-            }
-            else {
+            } else {
                 removeEdgeContainersIfNeeded()
             }
         }
     }
 
     /// - Parameter pagesCount: number of pages
-    /// - Parameter scrollDirection: indicates the target slide direction
+    /// - Parameter slideDirection: indicates the target slide direction
     init(pagesCount: Int, slideDirection: SlideDirection) {
         self.slideDirection = slideDirection
         slideContentView = SlideContentView(slideDirection: slideDirection)