Skip to content

Commit f60a63c

Browse files
committed
Merge bitcoin-core/gui#577: Getting ready to Qt 6 (1/n)
6312575 qt: Update deprecated enum value (Hennadii Stepanov) c7add88 qt: Use `|` instead of `+` for key modifiers (Hennadii Stepanov) 6f1e162 qt: Fix headers (Hennadii Stepanov) Pull request description: For Qt 5 all changes in this PR are refactoring. But for [Qt 6](bitcoin/bitcoin#24798) they are real bugfixes :) As I do not provide anyway way to build `bitcoin-qt` against Qt 6.2.4 fir now, suggesting to reviewers to verify changes for Qt 5 only. ACKs for top commit: shaavan: ACK 6312575 jarolrod: tACK bitcoin-core/gui@6312575 Tree-SHA512: ceee983192ddf62f09c1305458af3447ff0e3bd90311fa6328b139673bcaed3407dc0ce0b275028d4e0ca251d6b54dad40b48049211aeb251f65cbb4f5330834
2 parents f509760 + 6312575 commit f60a63c

File tree

4 files changed

+6
-5
lines changed

4 files changed

+6
-5
lines changed

src/qt/bitcoingui.cpp

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@
4141
#include <validation.h>
4242

4343
#include <QAction>
44+
#include <QActionGroup>
4445
#include <QApplication>
4546
#include <QComboBox>
4647
#include <QCursor>
@@ -355,7 +356,7 @@ void BitcoinGUI::createActions()
355356
showHelpMessageAction->setStatusTip(tr("Show the %1 help message to get a list with possible Bitcoin command-line options").arg(PACKAGE_NAME));
356357

357358
m_mask_values_action = new QAction(tr("&Mask values"), this);
358-
m_mask_values_action->setShortcut(QKeySequence(Qt::CTRL + Qt::SHIFT + Qt::Key_M));
359+
m_mask_values_action->setShortcut(QKeySequence(Qt::CTRL | Qt::SHIFT | Qt::Key_M));
359360
m_mask_values_action->setStatusTip(tr("Mask the values in the Overview tab"));
360361
m_mask_values_action->setCheckable(true);
361362

@@ -426,8 +427,8 @@ void BitcoinGUI::createActions()
426427
}
427428
#endif // ENABLE_WALLET
428429

429-
connect(new QShortcut(QKeySequence(Qt::CTRL + Qt::SHIFT + Qt::Key_C), this), &QShortcut::activated, this, &BitcoinGUI::showDebugWindowActivateConsole);
430-
connect(new QShortcut(QKeySequence(Qt::CTRL + Qt::SHIFT + Qt::Key_D), this), &QShortcut::activated, this, &BitcoinGUI::showDebugWindow);
430+
connect(new QShortcut(QKeySequence(Qt::CTRL | Qt::SHIFT | Qt::Key_C), this), &QShortcut::activated, this, &BitcoinGUI::showDebugWindowActivateConsole);
431+
connect(new QShortcut(QKeySequence(Qt::CTRL | Qt::SHIFT | Qt::Key_D), this), &QShortcut::activated, this, &BitcoinGUI::showDebugWindow);
431432
}
432433

433434
void BitcoinGUI::createMenuBar()

src/qt/coincontroldialog.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -588,7 +588,7 @@ void CoinControlDialog::updateView()
588588
ui->treeWidget->setEnabled(false); // performance, otherwise updateLabels would be called for every checked checkbox
589589
ui->treeWidget->setAlternatingRowColors(!treeMode);
590590
QFlags<Qt::ItemFlag> flgCheckbox = Qt::ItemIsSelectable | Qt::ItemIsEnabled | Qt::ItemIsUserCheckable;
591-
QFlags<Qt::ItemFlag> flgTristate = Qt::ItemIsSelectable | Qt::ItemIsEnabled | Qt::ItemIsUserCheckable | Qt::ItemIsTristate;
591+
QFlags<Qt::ItemFlag> flgTristate = Qt::ItemIsSelectable | Qt::ItemIsEnabled | Qt::ItemIsUserCheckable | Qt::ItemIsAutoTristate;
592592

593593
int nDisplayUnit = model->getOptionsModel()->getDisplayUnit();
594594

src/qt/guiutil.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,7 @@
6060
#include <QSettings>
6161
#include <QShortcut>
6262
#include <QSize>
63+
#include <QStandardPaths>
6364
#include <QString>
6465
#include <QTextDocument> // for Qt::mightBeRichText
6566
#include <QThread>

src/qt/walletview.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@
2323
#include <util/strencodings.h>
2424

2525
#include <QAction>
26-
#include <QActionGroup>
2726
#include <QFileDialog>
2827
#include <QHBoxLayout>
2928
#include <QProgressDialog>

0 commit comments

Comments
 (0)