|
3 | 3 | // file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
4 | 4 |
|
5 | 5 | #include <test/util/setup_common.h>
|
| 6 | +#include <univalue.h> |
| 7 | +#include <util/settings.h> |
6 | 8 | #include <util/strencodings.h>
|
7 | 9 | #include <util/system.h>
|
8 | 10 |
|
@@ -41,6 +43,116 @@ void SetupArgs(ArgsManager& local_args, const std::vector<std::pair<std::string,
|
41 | 43 | }
|
42 | 44 | }
|
43 | 45 |
|
| 46 | +// Test behavior of GetArg functions when string, integer, and boolean types |
| 47 | +// are specified in the settings.json file. GetArg functions are convenience |
| 48 | +// functions. The GetSetting method can always be used instead of GetArg |
| 49 | +// methods to retrieve original values, and there's not always an objective |
| 50 | +// answer to what GetArg behavior is best in every case. This test makes sure |
| 51 | +// there's test coverage for whatever the current behavior is, so it's not |
| 52 | +// broken or changed unintentionally. |
| 53 | +BOOST_AUTO_TEST_CASE(setting_args) |
| 54 | +{ |
| 55 | + ArgsManager args; |
| 56 | + SetupArgs(args, {{"-foo", ArgsManager::ALLOW_ANY}}); |
| 57 | + |
| 58 | + auto set_foo = [&](const util::SettingsValue& value) { |
| 59 | + args.LockSettings([&](util::Settings& settings) { |
| 60 | + settings.rw_settings["foo"] = value; |
| 61 | + }); |
| 62 | + }; |
| 63 | + |
| 64 | + set_foo("str"); |
| 65 | + BOOST_CHECK_EQUAL(args.GetSetting("foo").write(), "\"str\""); |
| 66 | + BOOST_CHECK_EQUAL(args.GetArg("foo", "default"), "str"); |
| 67 | + BOOST_CHECK_EQUAL(args.GetIntArg("foo", 100), 0); |
| 68 | + BOOST_CHECK_EQUAL(args.GetBoolArg("foo", true), false); |
| 69 | + BOOST_CHECK_EQUAL(args.GetBoolArg("foo", false), false); |
| 70 | + |
| 71 | + set_foo("99"); |
| 72 | + BOOST_CHECK_EQUAL(args.GetSetting("foo").write(), "\"99\""); |
| 73 | + BOOST_CHECK_EQUAL(args.GetArg("foo", "default"), "99"); |
| 74 | + BOOST_CHECK_EQUAL(args.GetIntArg("foo", 100), 99); |
| 75 | + BOOST_CHECK_EQUAL(args.GetBoolArg("foo", true), true); |
| 76 | + BOOST_CHECK_EQUAL(args.GetBoolArg("foo", false), true); |
| 77 | + |
| 78 | + set_foo("3.25"); |
| 79 | + BOOST_CHECK_EQUAL(args.GetSetting("foo").write(), "\"3.25\""); |
| 80 | + BOOST_CHECK_EQUAL(args.GetArg("foo", "default"), "3.25"); |
| 81 | + BOOST_CHECK_EQUAL(args.GetIntArg("foo", 100), 3); |
| 82 | + BOOST_CHECK_EQUAL(args.GetBoolArg("foo", true), true); |
| 83 | + BOOST_CHECK_EQUAL(args.GetBoolArg("foo", false), true); |
| 84 | + |
| 85 | + set_foo("0"); |
| 86 | + BOOST_CHECK_EQUAL(args.GetSetting("foo").write(), "\"0\""); |
| 87 | + BOOST_CHECK_EQUAL(args.GetArg("foo", "default"), "0"); |
| 88 | + BOOST_CHECK_EQUAL(args.GetIntArg("foo", 100), 0); |
| 89 | + BOOST_CHECK_EQUAL(args.GetBoolArg("foo", true), false); |
| 90 | + BOOST_CHECK_EQUAL(args.GetBoolArg("foo", false), false); |
| 91 | + |
| 92 | + set_foo(""); |
| 93 | + BOOST_CHECK_EQUAL(args.GetSetting("foo").write(), "\"\""); |
| 94 | + BOOST_CHECK_EQUAL(args.GetArg("foo", "default"), ""); |
| 95 | + BOOST_CHECK_EQUAL(args.GetIntArg("foo", 100), 0); |
| 96 | + BOOST_CHECK_EQUAL(args.GetBoolArg("foo", true), true); |
| 97 | + BOOST_CHECK_EQUAL(args.GetBoolArg("foo", false), true); |
| 98 | + |
| 99 | + set_foo(99); |
| 100 | + BOOST_CHECK_EQUAL(args.GetSetting("foo").write(), "99"); |
| 101 | + BOOST_CHECK_THROW(args.GetArg("foo", "default"), std::runtime_error); |
| 102 | + BOOST_CHECK_EQUAL(args.GetIntArg("foo", 100), 99); |
| 103 | + BOOST_CHECK_THROW(args.GetBoolArg("foo", true), std::runtime_error); |
| 104 | + BOOST_CHECK_THROW(args.GetBoolArg("foo", false), std::runtime_error); |
| 105 | + |
| 106 | + set_foo(3.25); |
| 107 | + BOOST_CHECK_EQUAL(args.GetSetting("foo").write(), "3.25"); |
| 108 | + BOOST_CHECK_THROW(args.GetArg("foo", "default"), std::runtime_error); |
| 109 | + BOOST_CHECK_THROW(args.GetIntArg("foo", 100), std::runtime_error); |
| 110 | + BOOST_CHECK_THROW(args.GetBoolArg("foo", true), std::runtime_error); |
| 111 | + BOOST_CHECK_THROW(args.GetBoolArg("foo", false), std::runtime_error); |
| 112 | + |
| 113 | + set_foo(0); |
| 114 | + BOOST_CHECK_EQUAL(args.GetSetting("foo").write(), "0"); |
| 115 | + BOOST_CHECK_THROW(args.GetArg("foo", "default"), std::runtime_error); |
| 116 | + BOOST_CHECK_EQUAL(args.GetIntArg("foo", 100), 0); |
| 117 | + BOOST_CHECK_THROW(args.GetBoolArg("foo", true), std::runtime_error); |
| 118 | + BOOST_CHECK_THROW(args.GetBoolArg("foo", false), std::runtime_error); |
| 119 | + |
| 120 | + set_foo(true); |
| 121 | + BOOST_CHECK_EQUAL(args.GetSetting("foo").write(), "true"); |
| 122 | + BOOST_CHECK_EQUAL(args.GetArg("foo", "default"), "1"); |
| 123 | + BOOST_CHECK_EQUAL(args.GetIntArg("foo", 100), 1); |
| 124 | + BOOST_CHECK_EQUAL(args.GetBoolArg("foo", true), true); |
| 125 | + BOOST_CHECK_EQUAL(args.GetBoolArg("foo", false), true); |
| 126 | + |
| 127 | + set_foo(false); |
| 128 | + BOOST_CHECK_EQUAL(args.GetSetting("foo").write(), "false"); |
| 129 | + BOOST_CHECK_EQUAL(args.GetArg("foo", "default"), "0"); |
| 130 | + BOOST_CHECK_EQUAL(args.GetIntArg("foo", 100), 0); |
| 131 | + BOOST_CHECK_EQUAL(args.GetBoolArg("foo", true), false); |
| 132 | + BOOST_CHECK_EQUAL(args.GetBoolArg("foo", false), false); |
| 133 | + |
| 134 | + set_foo(UniValue::VOBJ); |
| 135 | + BOOST_CHECK_EQUAL(args.GetSetting("foo").write(), "{}"); |
| 136 | + BOOST_CHECK_THROW(args.GetArg("foo", "default"), std::runtime_error); |
| 137 | + BOOST_CHECK_THROW(args.GetIntArg("foo", 100), std::runtime_error); |
| 138 | + BOOST_CHECK_THROW(args.GetBoolArg("foo", true), std::runtime_error); |
| 139 | + BOOST_CHECK_THROW(args.GetBoolArg("foo", false), std::runtime_error); |
| 140 | + |
| 141 | + set_foo(UniValue::VARR); |
| 142 | + BOOST_CHECK_EQUAL(args.GetSetting("foo").write(), "[]"); |
| 143 | + BOOST_CHECK_THROW(args.GetArg("foo", "default"), std::runtime_error); |
| 144 | + BOOST_CHECK_THROW(args.GetIntArg("foo", 100), std::runtime_error); |
| 145 | + BOOST_CHECK_THROW(args.GetBoolArg("foo", true), std::runtime_error); |
| 146 | + BOOST_CHECK_THROW(args.GetBoolArg("foo", false), std::runtime_error); |
| 147 | + |
| 148 | + set_foo(UniValue::VNULL); |
| 149 | + BOOST_CHECK_EQUAL(args.GetSetting("foo").write(), "null"); |
| 150 | + BOOST_CHECK_EQUAL(args.GetArg("foo", "default"), "default"); |
| 151 | + BOOST_CHECK_EQUAL(args.GetIntArg("foo", 100), 100); |
| 152 | + BOOST_CHECK_EQUAL(args.GetBoolArg("foo", true), true); |
| 153 | + BOOST_CHECK_EQUAL(args.GetBoolArg("foo", false), false); |
| 154 | +} |
| 155 | + |
44 | 156 | BOOST_AUTO_TEST_CASE(boolarg)
|
45 | 157 | {
|
46 | 158 | ArgsManager local_args;
|
|
0 commit comments