add isPow2 precaution

tomeksowi · tomeksowi · commit 749b3c560733 · 2025-07-11T14:27:26.000+02:00
diff --git a/src/coreclr/jit/ifconversion.cpp b/src/coreclr/jit/ifconversion.cpp
@@ -799,12 +799,12 @@ static IntConstSelectOper MatchIntConstSelectValues(int64_t trueVal, int64_t fal
     {
         unsigned bitIndex = BitOperations::Log2((uint64_t)trueVal);
         assert(bitIndex > 0);
-        if (trueVal == (int64_t(1) << bitIndex))
+        if (isPow2((uint64_t)trueVal) && trueVal == (int64_t(1) << bitIndex))
             return {GT_LSH, TYP_LONG, bitIndex};
 
         bitIndex = BitOperations::Log2((uint32_t)trueVal);
         assert(bitIndex > 0);
-        if (trueVal == int64_t(int32_t(int32_t(1) << bitIndex)))
+        if (isPow2((uint32_t)trueVal) && trueVal == int64_t(int32_t(int32_t(1) << bitIndex)))
             return {GT_LSH, TYP_INT, bitIndex};
     }
 

Original file line number	Diff line number	Diff line change
`@@ -799,12 +799,12 @@ static IntConstSelectOper MatchIntConstSelectValues(int64_t trueVal, int64_t fal`
`799`	`799`	`{`
`800`	`800`	`unsigned bitIndex = BitOperations::Log2((uint64_t)trueVal);`
`801`	`801`	`assert(bitIndex > 0);`
`802`		`- if (trueVal == (int64_t(1) << bitIndex))`
	`802`	`+ if (isPow2((uint64_t)trueVal) && trueVal == (int64_t(1) << bitIndex))`
`803`	`803`	`return {GT_LSH, TYP_LONG, bitIndex};`
`804`	`804`
`805`	`805`	`bitIndex = BitOperations::Log2((uint32_t)trueVal);`
`806`	`806`	`assert(bitIndex > 0);`
`807`		`- if (trueVal == int64_t(int32_t(int32_t(1) << bitIndex)))`
	`807`	`+ if (isPow2((uint32_t)trueVal) && trueVal == int64_t(int32_t(int32_t(1) << bitIndex)))`
`808`	`808`	`return {GT_LSH, TYP_INT, bitIndex};`
`809`	`809`	`}`
`810`	`810`