Clean up warnings

Author: djc

tracing-journald/src/lib.rs

@@ -515,11 +515,11 @@ pub struct PriorityMappings {
 impl PriorityMappings {
     /// Returns the default priority mappings:
     ///
-    /// - [`tracing::Level::ERROR`]: [`Priority::Error`] (3)
-    /// - [`tracing::Level::WARN`]: [`Priority::Warning`] (4)
-    /// - [`tracing::Level::INFO`]: [`Priority::Notice`] (5)
-    /// - [`tracing::Level::DEBUG`]: [`Priority::Informational`] (6)
-    /// - [`tracing::Level::TRACE`]: [`Priority::Debug`] (7)
+    /// - [`tracing::Level::ERROR`][]: [`Priority::Error`] (3)
+    /// - [`tracing::Level::WARN`][]: [`Priority::Warning`] (4)
+    /// - [`tracing::Level::INFO`][]: [`Priority::Notice`] (5)
+    /// - [`tracing::Level::DEBUG`][]: [`Priority::Informational`] (6)
+    /// - [`tracing::Level::TRACE`][]: [`Priority::Debug`] (7)
     pub fn new() -> PriorityMappings {
         Self {
             error: Priority::Error,

tracing-log/src/interest_cache.rs

@@ -499,9 +499,9 @@ mod tests {
                 .target("dummy_2")
                 .build();
             try_cache(&metadata_1, || true);
-            assert_eq!(try_cache(&metadata_1, || { unreachable!() }), true);
+            assert!(try_cache(&metadata_1, || { unreachable!() }));
             try_cache(&metadata_2, || false);
-            assert_eq!(try_cache(&metadata_2, || { unreachable!() }), false);
+            assert!(!try_cache(&metadata_2, || { unreachable!() }));
         })
         .join()
         .unwrap();
@@ -521,7 +521,7 @@ mod tests {
                 .build();
 
             try_cache(&metadata_1, || true);
-            assert_eq!(try_cache(&metadata_1, || { unreachable!() }), true);
+            assert!(try_cache(&metadata_1, || { unreachable!() }));
 
             *target.last_mut().unwrap() = b'2';
             let metadata_2 = log::MetadataBuilder::new()
@@ -530,7 +530,7 @@ mod tests {
                 .build();
 
             try_cache(&metadata_2, || false);
-            assert_eq!(try_cache(&metadata_2, || { unreachable!() }), false);
+            assert!(!try_cache(&metadata_2, || { unreachable!() }));
         })
         .join()
         .unwrap();

tracing-subscriber/src/fmt/time/chrono_crate.rs

@@ -1,15 +1,15 @@
+//! Formats [local time]s and [UTC time]s with `FormatTime` implementations
+//! that use the [`chrono` crate].
+//!
+//! [local time]: [`chrono::offset::Local`]
+//! [UTC time]: [`chrono::offset::Utc`]
+//! [`chrono` crate]: [`chrono`]
+
 use crate::fmt::format::Writer;
 use crate::fmt::time::FormatTime;
 
 use std::sync::Arc;
 
-/// Formats [local time]s and [UTC time]s with `FormatTime` implementations
-/// that use the [`chrono` crate].
-///
-/// [local time]: [`chrono::offset::Local`]
-/// [UTC time]: [`chrono::offset::Utc`]
-/// [`chrono` crate]: [`chrono`]
-
 /// Formats the current [local time] using a [formatter] from the [`chrono`] crate.
 ///
 /// [local time]: chrono::Local::now()

tracing/src/lib.rs

@@ -1080,7 +1080,7 @@ pub mod log {
         pub(crate) is_first: bool,
     }
 
-    impl<'a> fmt::Display for LogValueSet<'a> {
+    impl fmt::Display for LogValueSet<'_> {
         #[inline]
         fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
             struct LogVisitor<'a, 'b> {