Skip to content

Commit 84f0a60

Browse files
committed
chore: remove env_logger from hyper example
Currently, the `hyper_echo` example uses the `tracing-log` env logger support for some weird reason. I believe this is due to Hyper previously using `log` rather than `tracing`. However, `hyper` now emits native `tracing` diagnostics, so all the `env_logger` nonsense can just be removed from the example. This branch does that.
1 parent 6cb6c27 commit 84f0a60

File tree

2 files changed

+2
-14
lines changed

2 files changed

+2
-14
lines changed

examples/Cargo.toml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,6 @@ serde_json = "1.0.82"
3030
futures = "0.3.21"
3131
tokio = { version = "1.20.0", features = ["full"] }
3232

33-
# env-logger example
34-
env_logger = "0.8.4"
35-
3633
# tower examples
3734
tower = { version = "0.4.13", features = ["full"] }
3835
http = "0.2.8"

examples/examples/hyper-echo.rs

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -89,18 +89,9 @@ async fn echo(req: Request<Body>) -> Result<Response<Body>, hyper::Error> {
8989

9090
#[tokio::main]
9191
async fn main() -> Result<(), Box<dyn std::error::Error>> {
92-
use tracing_log::env_logger::BuilderExt;
93-
94-
let collector = tracing_subscriber::fmt()
92+
tracing_subscriber::fmt()
9593
.with_max_level(Level::TRACE)
96-
.finish();
97-
let mut builder = env_logger::Builder::new();
98-
builder
99-
.filter(Some("hyper_echo"), log::LevelFilter::Off)
100-
.filter(Some("hyper"), log::LevelFilter::Trace)
101-
.emit_traces() // from `tracing_log::env_logger::BuilderExt`
102-
.try_init()?;
103-
tracing::collect::set_global_default(collector)?;
94+
.init();
10495

10596
let local_addr: std::net::SocketAddr = ([127, 0, 0, 1], 3000).into();
10697
let server_span = span!(Level::TRACE, "server", %local_addr);

0 commit comments

Comments
 (0)