Skip to content

Commit 571c530

Browse files
hdshawkw
authored andcommitted
chore: fixes for clippy changes in Rust 1.74 (#2814)
With the release of Rust 1.74, there are some new or modified clippy lints that need adaption in the code. The main change was the removal of the `private_in_public`. https://rust-lang.github.io/rfcs/2145-type-privacy.html Then two more changes were required, in one case to adhere a lint and the other to allow it. When talking about what an "application" needs to do when setting up `tracing-error`, it makes sense to include `fn main()` in the doctest, even though the lint recommends against it. ; Conflicts: ; examples/examples/map-traced-error.rs
1 parent 0e4a4be commit 571c530

File tree

11 files changed

+23
-11
lines changed

11 files changed

+23
-11
lines changed

tracing-appender/src/lib.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,8 @@
153153
overflowing_literals,
154154
path_statements,
155155
patterns_in_fns_without_body,
156-
private_in_public,
156+
private_interfaces,
157+
private_bounds,
157158
unconditional_recursion,
158159
unused,
159160
unused_allocation,

tracing-attributes/src/lib.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,8 @@
7070
overflowing_literals,
7171
path_statements,
7272
patterns_in_fns_without_body,
73-
private_in_public,
73+
private_interfaces,
74+
private_bounds,
7475
unconditional_recursion,
7576
unused_allocation,
7677
unused_comparisons,

tracing-core/src/lib.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,8 @@
135135
overflowing_literals,
136136
path_statements,
137137
patterns_in_fns_without_body,
138-
private_in_public,
138+
private_interfaces,
139+
private_bounds,
139140
unconditional_recursion,
140141
unused,
141142
unused_allocation,

tracing-error/src/lib.rs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -183,6 +183,7 @@
183183
html_logo_url = "https://raw.githubusercontent.com/tokio-rs/tracing/master/assets/logo-type.png",
184184
issue_tracker_base_url = "https://github.com/tokio-rs/tracing/issues/"
185185
)]
186+
#![allow(clippy::needless_doctest_main)]
186187
#![warn(
187188
missing_debug_implementations,
188189
missing_docs,
@@ -196,7 +197,8 @@
196197
overflowing_literals,
197198
path_statements,
198199
patterns_in_fns_without_body,
199-
private_in_public,
200+
private_interfaces,
201+
private_bounds,
200202
unconditional_recursion,
201203
unused,
202204
unused_allocation,

tracing-flame/src/lib.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,8 @@
124124
overflowing_literals,
125125
path_statements,
126126
patterns_in_fns_without_body,
127-
private_in_public,
127+
private_interfaces,
128+
private_bounds,
128129
unconditional_recursion,
129130
unused,
130131
unused_allocation,

tracing-futures/src/lib.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,8 @@
8787
overflowing_literals,
8888
path_statements,
8989
patterns_in_fns_without_body,
90-
private_in_public,
90+
private_interfaces,
91+
private_bounds,
9192
unconditional_recursion,
9293
unused,
9394
unused_allocation,

tracing-log/src/lib.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,8 @@
112112
overflowing_literals,
113113
path_statements,
114114
patterns_in_fns_without_body,
115-
private_in_public,
115+
private_interfaces,
116+
private_bounds,
116117
unconditional_recursion,
117118
unused,
118119
unused_allocation,

tracing-serde/src/lib.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -174,7 +174,8 @@
174174
overflowing_literals,
175175
path_statements,
176176
patterns_in_fns_without_body,
177-
private_in_public,
177+
private_interfaces,
178+
private_bounds,
178179
unconditional_recursion,
179180
unused,
180181
unused_allocation,

tracing-subscriber/src/lib.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,8 @@
186186
overflowing_literals,
187187
path_statements,
188188
patterns_in_fns_without_body,
189-
private_in_public,
189+
private_interfaces,
190+
private_bounds,
190191
unconditional_recursion,
191192
unused,
192193
unused_allocation,

tracing-tower/src/lib.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,8 @@
1616
overflowing_literals,
1717
path_statements,
1818
patterns_in_fns_without_body,
19-
private_in_public,
19+
private_interfaces,
20+
private_bounds,
2021
unconditional_recursion,
2122
unused,
2223
unused_allocation,

tracing/src/lib.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -929,7 +929,8 @@
929929
overflowing_literals,
930930
path_statements,
931931
patterns_in_fns_without_body,
932-
private_in_public,
932+
private_interfaces,
933+
private_bounds,
933934
unconditional_recursion,
934935
unused,
935936
unused_allocation,

0 commit comments

Comments
 (0)