update go

Author: nikandfor

.circleci/config.yml

@@ -1,14 +1,19 @@
 version: 2
 jobs:
-  go1.23: &base
+  go1.24: &base
     docker:
-      - image: cimg/go:1.23
+      - image: cimg/go:1.24
     steps:
       - run: go version
       - checkout
       - run: go test -tags nikandfor_loc_unsafe -v ./...
       - run: go test -tags nikandfor_loc_unsafe -v -race ./...
 
+  go1.23:
+    <<: *base
+    docker:
+      - image: cimg/go:1.23
+
   go1.22:
     <<: *base
     docker:
@@ -34,22 +39,22 @@ jobs:
     docker:
       - image: cimg/go:1.18
 
-  go1.17:
-    <<: *base
-    docker:
-      - image: cimg/go:1.17
 
-
-  go1.23_safe: &base_safe
+  go1.24_safe: &base_safe
     <<: *base
     docker:
-      - image: cimg/go:1.23
+      - image: cimg/go:1.24
     steps:
       - run: go version
       - checkout
       - run: go test -v -race ./...
       - run: go test -v ./...
 
+  go1.23_safe:
+    <<: *base_safe
+    docker:
+      - image: cimg/go:1.23
+
   go1.22_safe:
     <<: *base_safe
     docker:
@@ -70,25 +75,20 @@ jobs:
     docker:
       - image: cimg/go:1.19
 
-  go1.18_safe:
-    <<: *base_safe
-    docker:
-      - image: cimg/go:1.18
-
 workflows:
   version: 2
   build:
     jobs:
+      - go1.24_safe
       - go1.23_safe
       - go1.22_safe
       - go1.21_safe
       - go1.20_safe
       - go1.19_safe
-      - go1.18_safe
+      - go1.24
       - go1.23
       - go1.22
       - go1.21
       - go1.20
       - go1.19
       - go1.18
-      - go1.17

.github/workflows/go.yml

@@ -11,10 +11,10 @@ jobs:
     strategy:
       matrix:
         os: ["ubuntu-latest", "macos-latest", "windows-latest"]
-        go-ver: ["1.23", "1.22", "1.21", "1.20", "1.19"]
+        go-ver: ["1.24", "1.23", "1.22", "1.21", "1.20", "1.19"]
         include:
           - os: "ubuntu-latest"
-            go-ver: "1.23"
+            go-ver: "1.24"
             cover: true
 
     runs-on: ${{ matrix.os }}
@@ -40,6 +40,12 @@ jobs:
       - name: Test Race
         run: go test -race -v ./...
 
+      - name: Test Unsafe
+        run: go test -tags nikandfor_loc_unsafe -v ./...
+
+      - name: Test Unsafe Race
+        run: go test -race -tags nikandfor_loc_unsafe -v ./...
+
       - name: Upload coverage reports to Codecov
         uses: codecov/codecov-action@v4
         if: ${{ matrix.cover }}

.golangci.yml

@@ -1,5 +1,9 @@
 run:
   #modules-download-mode: readonly
+issues:
+  exclude:
+    - "padding"
+  exclude-rules:
 linters-settings:
   govet:
     check-shadowing: false

build_tag_test.go

@@ -0,0 +1,9 @@
+//go:build nikandfor_loc_unsafe
+
+package loc
+
+import "testing"
+
+func TestBuildTag(t *testing.T) {
+	t.Logf("build tag is set")
+}

location_test.go

@@ -3,11 +3,17 @@ package loc
 import (
 	"path"
 	"path/filepath"
+	"runtime"
+	"strings"
 	"testing"
 
 	"github.com/stretchr/testify/assert"
 )
 
+// padding
+// padding
+// padding
+
 func TestLocation(t *testing.T) {
 	testLocationInside(t)
 }
@@ -19,20 +25,26 @@ func testLocationInside(t *testing.T) {
 	name, file, line := pc.NameFileLine()
 	assert.Equal(t, "loc.testLocationInside", path.Base(name))
 	assert.Equal(t, "location_test.go", filepath.Base(file))
-	assert.Equal(t, 18, line)
+	assert.Equal(t, 24, line)
 }
 
 func TestLocationShort(t *testing.T) {
 	pc := Caller(0)
-	assert.Equal(t, "location_test.go:26", pc.String())
+	assert.Equal(t, "location_test.go:32", pc.String())
 }
 
 func TestLocation2(t *testing.T) {
 	func() {
 		func() {
 			l := FuncEntry(0)
 
-			assert.Equal(t, "location_test.go:32", l.String())
+			ver := runtime.Version()
+			exp := "location_test.go:38"
+			if strings.HasPrefix(ver, "go1.24") {
+				exp = "location_test.go:36"
+			}
+
+			assert.Equal(t, exp, l.String(), "ver: %v", ver)
 		}()
 	}()
 }

unsafe.go

@@ -8,4 +8,4 @@ func callers(skip int, pc []PC) int
 
 //go:noescape
 //go:linkname caller1 runtime.callers
-func caller1(skip int, pc *PC, len, cap int) int //nolint:predeclared
+func caller1(skip int, pc *PC, len, cap int) int //nolint:predeclared,revive